All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: John Keeping <john@keeping.me.uk>, Git List <git@vger.kernel.org>,
	Jeff King <peff@peff.net>
Subject: Re: [PATCH 1/2] t8005: avoid grep on non-ASCII data
Date: Sun, 21 Feb 2016 15:31:47 -0800	[thread overview]
Message-ID: <xmqqsi0l8wt8.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAPig+cQ9n4Eg73Uyeg_g_4wzebuwn8=0R-LMb8F9QLFxanwVVg@mail.gmail.com> (Eric Sunshine's message of "Sun, 21 Feb 2016 16:01:27 -0500")

Eric Sunshine <sunshine@sunshineco.com> writes:

> These tests all crash and burn with BSD sed (including Mac OS X) since
> you're not restricting yourself to BRE (basic regular expressions).
> You _could_ request extended regular expressions, which do work on
> those platforms, as well as with GNU sed:
>
>     sed -nEe "/^(author|summary) /p" ...

An obvious way to avoid any RE is to write it as two separate
statements.  As there are repeated invocations of this filtering
in this script, perhaps a helper function can hide this ugliness?

  parent reply	other threads:[~2016-02-21 23:31 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-07 16:25 Test failures with GNU grep 2.23 John Keeping
2016-02-19 11:59 ` Jeff King
2016-02-19 17:27   ` Eric Sunshine
2016-02-19 17:38   ` Junio C Hamano
2016-02-19 19:11     ` Jeff King
2016-02-19 19:23     ` John Keeping
2016-02-19 19:33       ` Jeff King
2016-02-21 17:32         ` [PATCH 0/2] Fix test " John Keeping
2016-02-21 17:32           ` [PATCH 1/2] t8005: avoid grep on non-ASCII data John Keeping
2016-02-21 21:01             ` Eric Sunshine
2016-02-21 23:19               ` Jeff King
2016-02-21 23:31                 ` Eric Sunshine
2016-02-21 23:35                   ` Jeff King
2016-02-21 23:41                 ` John Keeping
2016-02-21 23:50                   ` Eric Sunshine
2016-02-22 22:18                   ` Jeff King
2016-02-22 22:25                     ` Junio C Hamano
2016-02-23 23:01                   ` Junio C Hamano
2016-02-24 10:24                     ` John Keeping
2016-02-21 23:31               ` Junio C Hamano [this message]
2016-02-21 23:40                 ` Eric Sunshine
2016-02-21 17:32           ` [PATCH 2/2] t9200: " John Keeping
2016-02-21 21:15             ` Eric Sunshine
2016-02-21 23:43               ` John Keeping
2016-02-22  0:04                 ` Eric Sunshine
2016-02-22 22:25                 ` Jeff King
2016-02-23 22:55                   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqsi0l8wt8.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=john@keeping.me.uk \
    --cc=peff@peff.net \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.