All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: David Turner <dturner@twopensource.com>
Cc: git@vger.kernel.org, David Turner <dturner@twitter.com>
Subject: Re: [PATCH v5 3/4] cache-tree: subdirectory tests
Date: Tue, 08 Jul 2014 10:38:07 -0700	[thread overview]
Message-ID: <xmqqsimbagzk.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1404779625-16972-3-git-send-email-dturner@twitter.com> (David Turner's message of "Mon, 7 Jul 2014 17:33:44 -0700")

David Turner <dturner@twopensource.com> writes:

> +	printf "invalid                                  %s ()\n" "" "$@" >expect &&
> +	test-dump-cache-tree | \
> +	sed -n -e "s/$_x40/SHA/" -e "s/[0-9]* subtrees//g" -e '/#(ref)/d' -e '/^invalid /p' >actual &&

You only show lines that begin with "invalid ".  Does the first
"redact any object name to S H A" matter?  Also do more than one "N
subtrees" appear on an output line?

> +	test_cmp expect actual
>  }
>  
>  test_no_cache_tree () {
> @@ -49,6 +50,25 @@ test_expect_success 'git-add invalidates cache-tree' '
>  	test_invalid_cache_tree
>  '
>  
> +test_expect_success 'git-add in subdir invalidates cache-tree' '
> +	test_when_finished "git reset --hard; git read-tree HEAD" &&
> +	mkdir dirx &&
> +	echo "I changed this file" >dirx/foo &&
> +	git add dirx/foo &&
> +	test_invalid_cache_tree
> +'
> +
> +test_expect_success 'git-add in subdir does not invalidate sibling cache-tree' '
> +	git tag no-children &&
> +	test_when_finished "git reset --hard no-children; git read-tree HEAD" &&
> +	mkdir dir1 dir2 &&
> +	test_commit dir1/a &&
> +	test_commit dir2/b &&
> +	echo "I changed this file" >dir1/a &&
> +	git add dir1/a &&
> +	test_invalid_cache_tree dir1/
> +'
> +
>  test_expect_success 'update-index invalidates cache-tree' '
>  	test_when_finished "git reset --hard; git read-tree HEAD" &&
>  	echo "I changed this file" >foo &&

  reply	other threads:[~2014-07-08 17:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-08  0:33 [PATCH v5 1/4] cache-tree: Create/update cache-tree on checkout David Turner
2014-07-08  0:33 ` [PATCH v5 2/4] test-dump-cache-tree: invalid trees are not errors David Turner
2014-07-08  0:33 ` [PATCH v5 3/4] cache-tree: subdirectory tests David Turner
2014-07-08 17:38   ` Junio C Hamano [this message]
2014-07-08  0:33 ` [PATCH v5 4/4] cache-tree: Write updated cache-tree after commit David Turner
2014-07-08 17:55   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqsimbagzk.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=dturner@twitter.com \
    --cc=dturner@twopensource.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.