All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Is column.ui.* configuration a bit too strong?
Date: Mon, 23 Jun 2014 12:03:11 -0700	[thread overview]
Message-ID: <xmqqsimvbg9c.fsf@gitster.dls.corp.google.com> (raw)

Since its inception at 7e29b825 (Add column layout skeleton and
git-column, 2012-04-21), it seems that git_column_config() asked for
a specific $command did not give "column.$command.*" any precedence
over the fallback value defined for "column.ui.*".  If you happen to
have column.ui.* earlier than the corresponding column.$command.* in
your configuration, then the values come from column.ui.* may be
overwritten, but the code does not seem to enforce "if there is a
setting for a specific command, honor that, otherwise fall back to
the generic 'ui' setting".

Am I misreading the code?

             reply	other threads:[~2014-06-23 19:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-23 19:03 Junio C Hamano [this message]
2014-06-24 12:00 ` Is column.ui.* configuration a bit too strong? Duy Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqsimvbg9c.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.