All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
	rctay89@gmail.com, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH] Document the HTTP transport protocols
Date: Wed, 21 Aug 2013 11:45:33 -0700	[thread overview]
Message-ID: <xmqqsiy2uble.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1377092713-25434-1-git-send-email-pclouds@gmail.com> ("Nguyễn	Thái Ngọc Duy"'s message of "Wed, 21 Aug 2013 20:45:13 +0700")

Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:

>  This is basically the version from Tay Ray Chuan [1] with one more
>  proofreading round from me. My changes besides realignments are below.
>  There are TODOs remain but I think the document is valuable as it is.

Thanks.

>  On the topic, C Git's (maybe) violations on this spec are:
>  
>   - The client does not strip trailing slashes from $GIT_URL before
>     sending to the server, as described in section "URL Format".
>  
>   - The client does not check that HTTP status code is either 200 or
>     304 when receiving response in discovering references phase.
>
>   - The client verifies the first 5 bytes against pattern
>     "^[0-9a-fA-F]{4}#" instead of "^[0-9a-f]{4}#" as described in
>     section "discovering references".

Perhaps add these to "small projects ideas"?  The last one may want
to be phrased a bit better, though.  I needed to read it twice to
realize that you are saying "the client accepts hexadecimal using
uppercase alphabets where it should not".

  reply	other threads:[~2013-08-21 18:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21 13:45 [PATCH] Document the HTTP transport protocols Nguyễn Thái Ngọc Duy
2013-08-21 18:45 ` Junio C Hamano [this message]
2013-08-21 22:00 ` Jeff King
2013-08-22 11:27   ` Duy Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqsiy2uble.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    --cc=rctay89@gmail.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.