Re: [PATCH v4 2/3] advice: introduce advice scoping mechanism

[Junio C Hamano <gitster@pobox.com>]

Jeff King <peff@peff.net> writes:

> On Thu, Sep 17, 2026 at 05:03:50PM +0300, Vsevolod Myalitsin wrote:
>
>> Junio C Hamano writes:
>> > So to conclude the topic, we would only need this?
>> 
>> Yes, I think this is indeed where we were heading.
>
> Likewise, and the patch looks good to me from a quick read.
>
>> However, during the discussion I really liked the idea of passing a
>> pointer to the "advice_setting" to "vadvise()" instead of passing its
>> individual fields. It seems like a cleaner interface, even though it
>> is not directly related to this fix.
>> 
>> Would it make sense to submit that change as a separate patch?
>
> I think so. I probably would not have looked into it as a cleanup on its
> own, but since we already spent time thinking about it, let's not waste
> those brain cycles.

So I should mark jc/advice-config-set-global for 'next' and Vsevolod
can look into cleaning up the API as an independent effort?