All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  Harald Nordgren <haraldnordgren@gmail.com>
Subject: Re: [PATCH v2] send-email: clarify missing subject error
Date: Mon, 10 Aug 2026 14:09:28 -0700	[thread overview]
Message-ID: <xmqqtsp165tj.fsf@gitster.g> (raw)
In-Reply-To: <pull.2375.v2.git.git.1786384412423.gitgitgadget@gmail.com> (Harald Nordgren via GitGitGadget's message of "Mon, 10 Aug 2026 17:53:32 +0000")

"Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com> writes:

> +test_expect_success $PREREQ 'missing subject omits Perl location' '
> +	cat >no-subject.patch <<-\EOF &&
> +	This is the body.
> +	EOF
> +	test_must_fail git send-email \
> +		--dry-run \
> +		--from="Example <nobody@example.com>" \
> +		--to=nobody@example.com \
> +		no-subject.patch 2>actual &&
> +	cat >expect <<-\EOF &&
> +	No '\''Subject:'\'' line in '\''no-subject.patch'\''
> +	EOF

OK.  We require the message to exactly be this one (not starting
with this substring), which makes sure we are not getting the line
numbers from die.  Good.

Will queue.  This round looks perfect.  Let's mark it for 'next'.

Thanks.

      reply	other threads:[~2026-08-10 21:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-09  9:23 [PATCH] send-email: clarify missing subject error Harald Nordgren via GitGitGadget
2026-08-09 19:13 ` Junio C Hamano
2026-08-10  9:48   ` Harald Nordgren
2026-08-10 15:28     ` Junio C Hamano
2026-08-10 17:53 ` [PATCH v2] " Harald Nordgren via GitGitGadget
2026-08-10 21:09   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtsp165tj.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=haraldnordgren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.