From: Junio C Hamano <gitster@pobox.com>
To: "Ville Skyttä" <ville.skytta@iki.fi>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Documentation: a/an grammar fixes
Date: Wed, 29 Jul 2026 19:50:22 -0700 [thread overview]
Message-ID: <xmqqtsphmbrl.fsf@gitster.g> (raw)
In-Reply-To: <20260729182323.1095474-1-ville.skytta@iki.fi> ("Ville Skyttä"'s message of "Wed, 29 Jul 2026 21:23:23 +0300")
Ville Skyttä <ville.skytta@iki.fi> writes:
> This takes the stance that `*` is an asterisk rather than a star.
>
> Signed-off-by: Ville Skyttä <ville.skytta@iki.fi>
> ---
As long as the changes do not contain an incorrect rewrite, it is OK
even if the patch is not exhausitive. I went though the changes and
did not spot anything questionable.
But I think I can see a few more of the same kind. I didn't try to
bee exhaustive, either, though.
Documentation/config/gpg.adoc | 6 +++---
Documentation/git-push.adoc | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git i/Documentation/config/gpg.adoc w/Documentation/config/gpg.adoc
index 240e46c050..d4b8c1e570 100644
--- i/Documentation/config/gpg.adoc
+++ w/Documentation/config/gpg.adoc
@@ -38,7 +38,7 @@ gpg.minTrustLevel::
* `ultimate`
gpg.ssh.defaultKeyCommand::
- This command will be run when user.signingkey is not set and a ssh
+ This command will be run when user.signingkey is not set and an ssh
signature is requested. On successful exit a valid ssh public key
prefixed with `key::` is expected in the first line of its output.
This allows for a script doing a dynamic lookup of the correct public
@@ -75,11 +75,11 @@ valid-before options. Git will mark signatures as valid if the signing key was
valid at the time of the signature's creation. This allows users to change a
signing key without invalidating all previously made signatures.
+
-Using a SSH CA key with the cert-authority option
+Using an SSH CA key with the cert-authority option
(see ssh-keygen(1) "CERTIFICATES") is also valid.
gpg.ssh.revocationFile::
- Either a SSH KRL or a list of revoked public keys (without the principal prefix).
+ Either an SSH KRL or a list of revoked public keys (without the principal prefix).
See ssh-keygen(1) for details.
If a public key is found in this file then it will always be treated
as having trust level "never" and signatures will show as invalid.
diff --git i/Documentation/git-push.adoc w/Documentation/git-push.adoc
index aa221c3909..d05e6020a5 100644
--- i/Documentation/git-push.adoc
+++ w/Documentation/git-push.adoc
@@ -105,7 +105,7 @@ as well as various other special refspec forms:
directs Git to push "matching" branches: for every branch that exists on
the local side, the remote side is updated if a branch of the same name
already exists on the remote side.
- * _<src>_ may contain a `*` to indicate a simple pattern match.
+ * _<src>_ may contain an `*` to indicate a simple pattern match.
This works like a glob that matches any ref matching the pattern.
There must be only one `*` in both the `<src>` and `<dst>`.
It will map refs to the destination by replacing the * with the
prev parent reply other threads:[~2026-07-30 2:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 18:23 [PATCH] Documentation: a/an grammar fixes Ville Skyttä
2026-07-30 2:50 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtsphmbrl.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ville.skytta@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.