From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, "Torsten Bögershausen" <tboegi@web.de>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>
Subject: Re: [PATCH v2] t: allow use of "sed -E"
Date: Thu, 12 Mar 2026 06:43:45 -0700 [thread overview]
Message-ID: <xmqqtsuli2ni.fsf@gitster.g> (raw)
In-Reply-To: <abKG1U3fVuNV1w_9@fruit.crustytoothpaste.net> (brian m. carlson's message of "Thu, 12 Mar 2026 09:26:45 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> Yes, I think if nobody has complained about it in three years, we should
> be fine.
This actually started when I noticed a recent rewrite of a test that
turned "grep -E ... | sed -e ..." into "sed -E -e ..." was flagged
by the test-lint.
It is not a huge deal to rewrite the resulting sed script again to
use BRE instead of ERE and it may not be a bad idea doing so anyway
(and rewrite the existing t6030). That can be done independently.
next prev parent reply other threads:[~2026-03-12 13:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 21:35 [RFC] t: allow use of "sed -E" Junio C Hamano
2026-03-11 21:41 ` Junio C Hamano
2026-03-11 23:12 ` Ramsay Jones
2026-03-12 0:33 ` Junio C Hamano
2026-03-12 0:45 ` [PATCH v2] " Junio C Hamano
2026-03-12 6:41 ` Patrick Steinhardt
2026-03-12 9:26 ` brian m. carlson
2026-03-12 13:43 ` Junio C Hamano [this message]
2026-03-14 23:16 ` Todd Zullinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtsuli2ni.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
--cc=sunshine@sunshineco.com \
--cc=szeder.dev@gmail.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.