All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Phil Hord <phil.hord@gmail.com>
Cc: peff@peff.net,  git@vger.kernel.org,
	 Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [PATCH v4 0/3] fetch --prune performance problem
Date: Mon, 07 Jul 2025 15:43:12 -0700	[thread overview]
Message-ID: <xmqqtt3n1v27.fsf@gitster.g> (raw)
In-Reply-To: <20250702011214.2835529-2-phil.hord@gmail.com> (Phil Hord's message of "Tue, 1 Jul 2025 18:12:12 -0700")

Phil Hord <phil.hord@gmail.com> writes:

> From: Phil Hord <phil.hord@gmail.com>
>
> `git fetch --prune` runs in O(N^2) time normally. This happens because the code
> iterates over each ref to be pruned to display its status. In a repo with
> 174,000 refs, where I was pruning 15,000 refs, the current code made 2.6 billion
> calls to strcmp and consumed 470 seconds of CPU. After this change, the same
> operation completes in under 1 second.
> ...
> V3 forgot to include the first commit in the series (I forgot it grew).
> So here's V4.
>
> Phil Hord (3):
>   fetch-prune: optimize dangling-ref reporting
>   refs: remove old refs_warn_dangling_symref
>   clean up interface for refs_warn_dangling_symrefs

It seems that the thread has gone quiet.  What's the status of this
topic?

Thanks.


  parent reply	other threads:[~2025-07-07 22:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02  1:12 [PATCH v4 0/3] fetch --prune performance problem Phil Hord
2025-07-02  1:12 ` [PATCH v4 1/3] fetch-prune: optimize dangling-ref reporting Phil Hord
2025-07-02  1:12 ` [PATCH v4 2/3] refs: remove old refs_warn_dangling_symref Phil Hord
2025-07-02  1:12 ` [PATCH v4 3/3] clean up interface for refs_warn_dangling_symrefs Phil Hord
2025-07-08  1:35   ` Jeff King
2025-07-07 22:43 ` Junio C Hamano [this message]
2025-07-08  1:00   ` [PATCH v4 0/3] fetch --prune performance problem Phil Hord
2025-07-08  1:36   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtt3n1v27.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=peff@peff.net \
    --cc=phil.hord@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.