From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a4-smtp.messagingengine.com (fout-a4-smtp.messagingengine.com [103.168.172.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C5B84C6E for ; Sat, 29 Mar 2025 00:39:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.147 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743208767; cv=none; b=K5++tYVGWMH2eA2MM2D5TRUjFLZMG9FKE9lrKdERT87mYSwvPnZbueSPDXGCEdSp+AlSnRjSgogArL1b36Y7JDK7QMyjYgiRHt7nP3ZbehgA39L9H/PTjvJM8En8MWMqjHGixNosVcN9xlMd4Ve/R1zY9tw5kBLA39ekfC07GJU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743208767; c=relaxed/simple; bh=4j7n0UE3fl9RsbjZT8OoITpg2kZ4Ywxf4rRszKskucI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=WXAMGYtOHbbOFLF4NRbJGKTY2LFwF5ugQPMJjCGLMrxB53Ksua3A0Luyk9WwtBPkMyOWurNCRkjt7UT2bPfIvfIYwv2coEpCKajsZ6RoPC1MgtbVRg2JdVwuYRiJGm47XHp2PLkJ7RkjeHo4Lt3CTMARR0pZ9VP219FDlWEG24U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b=twQ/TafZ; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=WmZKTlV7; arc=none smtp.client-ip=103.168.172.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b="twQ/TafZ"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="WmZKTlV7" Received: from phl-compute-07.internal (phl-compute-07.phl.internal [10.202.2.47]) by mailfout.phl.internal (Postfix) with ESMTP id 719FF1383820; Fri, 28 Mar 2025 20:39:24 -0400 (EDT) Received: from phl-frontend-01 ([10.202.2.160]) by phl-compute-07.internal (MEProxy); Fri, 28 Mar 2025 20:39:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pobox.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1743208764; x=1743295164; bh=9o2sWQnF7g kJsAqHPLUI6tH8SSNuSoyWME/kNI0vVx0=; b=twQ/TafZxaWDo6gFFrFXWQSnKp KYBV44KJ7mZ10dmOp3eGIjvhkP4TwhSlqYru9gFqNPZVLcUwO6wEHwCuKO29w6ea Ko20hTxDEnir7XOfSqilgJEnh+537NAOpCL535KkAtzD73/OJucZl1icapq7DhPg YB1dp1aYSgiXcCy61QvlsxMOwjbggEqdCm74xNET9ZjiTbKmdbfiOqWzAFdUkq3M /pEl+OT4HUlbXAzO+rBoPRW45kLSfJjX64O8kCqEraMdMEWo8C+64ra4KH8pJhf1 03zIQFKwBZEXwWPlSr9UdR8sOPi8E58qP4phiGZTrctNs+mbjXE8IlbTozAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1743208764; x=1743295164; bh=9o2sWQnF7gkJsAqHPLUI6tH8SSNuSoyWME/ kNI0vVx0=; b=WmZKTlV7RSbsrJZmrjvwGaY0Yo6CMxoEmwz/NkeSG9Ctty9Flbe BmLV8QjuGz0jipdYEZnpUd3osHvJrarrkqbyP8p/n9bTuGh6Y2RVycccDrxi50XP y7cj1m+UPLSrRp/20KCfAjyS6bv4fDwup5gcAq3fnKj51pILvF+H6JYnKxk82LwE 42LykSo54IO7ia5KuB6sLOCyCVbcNCifKLodkS5vDcbBlzA0tCY/ZCsXVjOXT6yD ww2a8066fN7M4kFvqp1cN4AGpy8kRCzJmQsE2ff7Z8VRNYgNhyculhc9hi27qavB WiJJLv4O9ov1zsad7K2ic4GV9IqSbBn1qxA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddujedvjeehucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephffvvefujghffffkfgggtgesthdtredttder tdenucfhrhhomheplfhunhhiohcuvecujfgrmhgrnhhouceoghhithhsthgvrhesphhosg hogidrtghomheqnecuggftrfgrthhtvghrnhepfeevteetjeehueegffelvdetieevffeu feejleeuffetiefggfeftdfhfeeigeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepghhithhsthgvrhesphhosghogidrtghomhdpnhgspghr tghpthhtohepuddvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehphhhilhhlih hprdifohhougduvdefsehgmhgrihhlrdgtohhmpdhrtghpthhtohepghhithhgihhtghgr ughgvghtsehgmhgrihhlrdgtohhmpdhrtghpthhtohepghhithesvhhgvghrrdhkvghrnh gvlhdrohhrghdprhgtphhtthhopehphhhilhhiphhorghklhgvhiesihgvvgdrvghmrghi lhdprhgtphhtthhopehpshesphhkshdrihhmpdhrtghpthhtohepkhgrrhhthhhikhdrud ekkeesghhmrghilhdrtghomhdprhgtphhtthhopehpvghffhesphgvfhhfrdhnvghtpdhr tghpthhtohepmhgvsehtthgrhihlohhrrhdrtghomhdprhgtphhtthhopehsuhhnshhhih hnvgesshhunhhshhhinhgvtghordgtohhm X-ME-Proxy: Feedback-ID: if26b431b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 28 Mar 2025 20:39:23 -0400 (EDT) From: Junio C Hamano To: Phillip Wood Cc: Johannes Schindelin via GitGitGadget , git@vger.kernel.org, Philip Oakley , Patrick Steinhardt , Karthik Nayak , Jeff King , Taylor Blau , Eric Sunshine , Chris Torek , Johannes Schindelin Subject: Re: [PATCH v3 00/10] Avoid the comma operator In-Reply-To: <504e63df-77d2-4cd0-bdcc-bd9949d34ce5@gmail.com> (Phillip Wood's message of "Thu, 27 Mar 2025 15:07:17 +0000") References: <504e63df-77d2-4cd0-bdcc-bd9949d34ce5@gmail.com> Date: Fri, 28 Mar 2025 17:39:22 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Phillip Wood writes: > Hi Johannes > > On 27/03/2025 11:52, Johannes Schindelin via GitGitGadget wrote: >> Changes since v2: >> * Made the sed construct in detect-compiler portable (thanks, Eric >> Sunshine!) >> * The majority of the feedback disagreed with the more compact format in >> diff-delta.c, so I changed it to the long format (thanks, Phillip Wood!) >> * The more succinct and safer, but less readable, cast in the loop >> condition of the dowild() function was replaced with the goto-based >> alternative I had mentioned as a possibility in the commit message >> (thanks, Phillip Wood!) >> * I adjusted the style of my compat/regex/ patch to the surrounding code's. >> * The -Wcomma option is now used in Meson-based clang builds, too (thanks, >> Patrick Steinhardt!) > > The range-diff below looks good to me, thanks for making our code base > clearer. > > Best Wishes > > Phillip Yup, thanks Dscho, and all who gave valuable input to polish the series. Will queue.