All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Toon Claes <toon@iotcl.com>
Cc: git@vger.kernel.org,
	"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>,
	"Michal Suchánek" <msuchanek@suse.de>,
	"Patrick Steinhardt" <ps@pks.im>, "Jeff King" <peff@peff.net>
Subject: Re: [PATCH v5 0/7] Enable doing a shallow clone of a specific git revision
Date: Wed, 05 Feb 2025 06:09:00 -0800	[thread overview]
Message-ID: <xmqqtt98pjpf.fsf@gitster.g> (raw)
In-Reply-To: <20250204-toon-clone-refs-v5-0-37e34af283c8@iotcl.com> (Toon Claes's message of "Tue, 04 Feb 2025 22:33:59 +0100")

Toon Claes <toon@iotcl.com> writes:

> The goal of this series is to add an option `--revision` to
> git-clone(1).
>
> This series starts with a handful of preparatory refactoring commits
> that make it more straight-forward to add this new option. In the last
> commit we're actually adding the feature.
>
> This series sets an example on how I think we can further refactor
> builtin/clone.c to increase the maintainability of the code.
>
> ---
> Changes in v5:
> - Add separate commit to introduce die_for_incompatible_opt2()
> - Small tweaks in documentation about `--[no-]tags` and `--revision`.
> - Better explain the refactoring of wanted_peer_refs() in the commit
>   message.
> - Change type from `int` to `size_t` in wanted_peer_refs().
> - Use lookup_commit_or_die() instead lookup_commit_reference() to avoid
>   checking the result ourself.
> - Add a few code comments to explain some things.
> - Stylish cleanups like removal of unneeded empty lines, commented out
>   test-code and remarks.
> - Link to v4: https://lore.kernel.org/r/20250131-toon-clone-refs-v4-0-2a4ff851498f@iotcl.com

Looking good.  Queued.

  parent reply	other threads:[~2025-02-05 14:09 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-29 12:00 [PATCH v2] builtin/clone: teach git-clone(1) the --revision= option Toon Claes
2024-12-02 14:08 ` Patrick Steinhardt
2024-12-02 21:17   ` Jeff King
2024-12-03 15:34   ` Michal Suchánek
2024-12-19 11:23   ` Toon Claes
2024-12-19 11:58 ` [PATCH v3] " Toon Claes
2024-12-19 18:30   ` Junio C Hamano
2025-01-31 15:30   ` [PATCH v4 0/6] Enable doing a shallow clone of a specific git revision Toon Claes
2025-01-31 15:30     ` [PATCH v4 1/6] clone: cut down on global variables in clone.c Toon Claes
2025-01-31 15:30     ` [PATCH v4 2/6] clone: make it possible to specify --tags Toon Claes
2025-02-01 16:47       ` Jean-Noël AVILA
2025-01-31 15:30     ` [PATCH v4 3/6] clone: refactor wanted_peer_refs() Toon Claes
2025-02-03  7:51       ` Patrick Steinhardt
2025-01-31 15:30     ` [PATCH v4 4/6] clone: add tags refspec earlier to fetch refspec Toon Claes
2025-02-03  7:51       ` Patrick Steinhardt
2025-01-31 15:30     ` [PATCH v4 5/6] clone: introduce struct clone_opts in builtin/clone.c Toon Claes
2025-02-03  7:51       ` Patrick Steinhardt
2025-01-31 15:30     ` [PATCH v4 6/6] builtin/clone: teach git-clone(1) the --revision= option Toon Claes
2025-01-31 21:05       ` Junio C Hamano
2025-02-01 16:50       ` Jean-Noël AVILA
2025-02-03  7:51       ` Patrick Steinhardt
2025-02-04 21:33     ` [PATCH v5 0/7] Enable doing a shallow clone of a specific git revision Toon Claes
2025-02-04 21:34       ` [PATCH v5 1/7] clone: cut down on global variables in clone.c Toon Claes
2025-02-04 21:34       ` [PATCH v5 2/7] clone: make it possible to specify --tags Toon Claes
2025-02-05  8:03         ` Patrick Steinhardt
2025-02-05 16:29           ` Toon Claes
2025-02-05 21:15           ` Jean-Noël AVILA
2025-02-04 21:34       ` [PATCH v5 3/7] clone: refactor wanted_peer_refs() Toon Claes
2025-02-04 21:34       ` [PATCH v5 4/7] clone: add tags refspec earlier to fetch refspec Toon Claes
2025-02-05  8:03         ` Patrick Steinhardt
2025-02-04 21:34       ` [PATCH v5 5/7] clone: introduce struct clone_opts in builtin/clone.c Toon Claes
2025-02-04 21:34       ` [PATCH v5 6/7] parse-options: introduce die_for_incompatible_opt2() Toon Claes
2025-02-05  8:03         ` Patrick Steinhardt
2025-02-04 21:34       ` [PATCH v5 7/7] builtin/clone: teach git-clone(1) the --revision= option Toon Claes
2025-02-05  8:03         ` Patrick Steinhardt
2025-02-05 16:43           ` Toon Claes
2025-02-05  8:03       ` [PATCH v5 0/7] Enable doing a shallow clone of a specific git revision Patrick Steinhardt
2025-02-05 14:09       ` Junio C Hamano [this message]
2025-02-05 16:47       ` [PATCH v6 " Toon Claes
2025-02-05 16:47         ` [PATCH v6 1/7] clone: cut down on global variables in clone.c Toon Claes
2025-02-05 16:47         ` [PATCH v6 2/7] clone: make it possible to specify --tags Toon Claes
2025-02-05 16:47         ` [PATCH v6 3/7] clone: refactor wanted_peer_refs() Toon Claes
2025-02-05 16:47         ` [PATCH v6 4/7] clone: add tags refspec earlier to fetch refspec Toon Claes
2025-02-05 16:47         ` [PATCH v6 5/7] clone: introduce struct clone_opts in builtin/clone.c Toon Claes
2025-02-05 16:47         ` [PATCH v6 6/7] parse-options: introduce die_for_incompatible_opt2() Toon Claes
2025-02-05 16:47         ` [PATCH v6 7/7] builtin/clone: teach git-clone(1) the --revision= option Toon Claes
2025-02-05 17:24           ` Junio C Hamano
2025-02-06  6:33         ` [PATCH v7 0/7] Enable doing a shallow clone of a specific git revision Toon Claes
2025-02-06  6:33           ` [PATCH v7 1/7] clone: cut down on global variables in clone.c Toon Claes
2025-02-06  6:33           ` [PATCH v7 2/7] clone: make it possible to specify --tags Toon Claes
2025-02-06  6:33           ` [PATCH v7 3/7] clone: refactor wanted_peer_refs() Toon Claes
2025-02-06  6:33           ` [PATCH v7 4/7] clone: add tags refspec earlier to fetch refspec Toon Claes
2025-02-06  6:33           ` [PATCH v7 5/7] clone: introduce struct clone_opts in builtin/clone.c Toon Claes
2025-02-06  6:33           ` [PATCH v7 6/7] parse-options: introduce die_for_incompatible_opt2() Toon Claes
2025-02-06  6:33           ` [PATCH v7 7/7] builtin/clone: teach git-clone(1) the --revision= option Toon Claes
2025-02-06  8:13             ` Patrick Steinhardt
2025-02-06 20:26               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtt98pjpf.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=msuchanek@suse.de \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    --cc=toon@iotcl.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.