All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Justin Tobler <jltobler@gmail.com>
Cc: Karthik Nayak <karthik.188@gmail.com>,  git@vger.kernel.org
Subject: Re: [PATCH 1/3] clang-format: don't enforce the column limit
Date: Wed, 09 Oct 2024 15:32:19 -0700	[thread overview]
Message-ID: <xmqqttdkoqks.fsf@gitster.g> (raw)
In-Reply-To: <zmqyj3v2h3hswoujpz2er5luvjipjl3i4ts6xjdeb43wp42xf2@i5xee2lsmriz> (Justin Tobler's message of "Wed, 9 Oct 2024 10:45:45 -0500")

Justin Tobler <jltobler@gmail.com> writes:

> On 24/10/09 05:55AM, Karthik Nayak wrote:
>> The current value for the column limit is set to 80. While this is as
>> expected, we often prefer readability over this strict limit. This means
>> it is common to find code which extends over 80 characters. So let's
>> change the column limit to be 0 instead. This ensures that the formatter
>> doesn't complain about code strictly not following the column limit.
>
> The column limit does lead to quite a few false positives. At the same
> time though, in some ways having a tool point out all the instances it
> occurs does make it easier to review if any should be addressed.
>
> If the goal is to have a CI job that we generally expect to pass, then
> it makes sense to remove it. I don't feel super strongly either way.

Is it possible for gatekeeper jobs to complain only on newly added
violations?  Then it is fine to have a limit with a bit of slack,
say like 96 columns (with 16-column readability slack).


  reply	other threads:[~2024-10-09 22:32 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09 12:51 [PATCH 0/3] clang-format: fix rules to make the CI job cleaner Karthik Nayak
2024-10-09 12:55 ` [PATCH 1/3] clang-format: don't enforce the column limit Karthik Nayak
2024-10-09 15:45   ` Justin Tobler
2024-10-09 22:32     ` Junio C Hamano [this message]
2024-10-10 16:48       ` karthik nayak
2024-10-09 12:56 ` [PATCH 2/3] clang-format: don't align expressions after linebreaks Karthik Nayak
2024-10-09 12:56 ` [PATCH 3/3] clang-format: align consecutive macro definitions Karthik Nayak
2024-10-10  8:27   ` Toon Claes
2024-10-10 17:59 ` [PATCH v2 0/3] clang-format: fix rules to make the CI job cleaner Karthik Nayak
2024-10-10 17:59   ` [PATCH v2 1/3] clang-format: change column limit to 96 characters Karthik Nayak
2024-10-10 18:11     ` Kyle Lippincott
2024-10-10 19:49       ` karthik nayak
2024-10-10 20:09         ` Kyle Lippincott
2024-10-10 17:59   ` [PATCH v2 2/3] clang-format: don't align expressions after linebreaks Karthik Nayak
2024-10-10 17:59   ` [PATCH v2 3/3] clang-format: align consecutive macro definitions Karthik Nayak
2024-10-12  1:49 ` [PATCH v3 0/3] clang-format: fix rules to make the CI job cleaner Karthik Nayak
2024-10-12  1:49   ` [PATCH v3 1/3] clang-format: re-adjust line break penalties Karthik Nayak
2024-10-14  9:08     ` Toon Claes
2024-10-14 21:14       ` Taylor Blau
2024-10-15 11:35         ` karthik nayak
2024-10-15 11:20       ` karthik nayak
2024-10-14 20:59     ` Kyle Lippincott
2024-10-15 12:37       ` karthik nayak
2024-10-16  1:38         ` Kyle Lippincott
2024-10-16 21:17           ` karthik nayak
2024-10-12  1:49   ` [PATCH v3 2/3] clang-format: align consecutive macro definitions Karthik Nayak
2024-10-14 21:12     ` Kyle Lippincott
2024-10-15  7:57       ` karthik nayak
2024-10-12  1:49   ` [PATCH v3 3/3] clang-format: don't align expressions after linebreaks Karthik Nayak
2024-10-14 21:23     ` Kyle Lippincott
2024-10-15 11:17       ` karthik nayak
2024-10-18  8:46 ` [PATCH v4 0/2] Subject: clang-format: fix rules to make the CI job cleaner Karthik Nayak
2024-10-18  8:46   ` [PATCH v4 1/2] clang-format: re-adjust line break penalties Karthik Nayak
2024-10-25  2:37     ` Justin Tobler
2024-10-25  9:48       ` karthik nayak
2024-10-18  8:46   ` [PATCH v4 2/2] clang-format: align consecutive macro definitions Karthik Nayak
2024-10-18 21:37   ` [PATCH v4 0/2] Subject: clang-format: fix rules to make the CI job cleaner Taylor Blau
2024-10-20 11:17     ` karthik nayak
2024-10-21 21:48       ` Taylor Blau
2024-10-22  8:31         ` karthik nayak
2024-10-22 16:42           ` Taylor Blau
     [not found] <20241009125109.24422-1-karthik.188@gmail.com>
2024-10-09 12:51 ` [PATCH 1/3] clang-format: don't enforce the column limit Karthik Nayak
2024-10-09 12:58   ` Karthik Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqttdkoqks.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jltobler@gmail.com \
    --cc=karthik.188@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.