From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 10/16] refs: move object peeling into "object.c"
Date: Thu, 16 May 2024 13:55:42 -0700 [thread overview]
Message-ID: <xmqqttixo4s1.fsf@gitster.g> (raw)
In-Reply-To: <f03626ac0025050e49cad4057e6f3b3e7c7c141c.1715836916.git.ps@pks.im> (Patrick Steinhardt's message of "Thu, 16 May 2024 10:04:58 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> Peeling an object has nothing to do with refs, but we still have the
> code in "refs.c". Move it over into "object.c", which is a more natural
> place to put it.
Yay! Very nice.
> Ideally, we'd also move `peel_iterated_oid()` over into "object.c". But
> this function is tied to the refs interfaces because it uses a global
> ref iterator variable to optimize peeling when the iterator already has
> the peeled object ID readily available.
Sure.
next prev parent reply other threads:[~2024-05-16 20:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 8:04 [PATCH 00/16] refs: drop all references to `the_repository` Patrick Steinhardt
2024-05-16 8:04 ` [PATCH 01/16] refs: adjust names for `init` and `init_db` callbacks Patrick Steinhardt
2024-05-16 14:50 ` Karthik Nayak
2024-05-16 8:04 ` [PATCH 02/16] refs: rename `init_db` callback to avoid confusion Patrick Steinhardt
2024-05-16 15:00 ` Karthik Nayak
2024-05-16 18:24 ` Junio C Hamano
2024-05-17 7:08 ` Patrick Steinhardt
2024-05-16 8:04 ` [PATCH 03/16] refs: implement releasing ref storages Patrick Steinhardt
2024-05-16 16:39 ` Karthik Nayak
2024-05-16 18:01 ` Junio C Hamano
2024-05-17 7:09 ` Patrick Steinhardt
2024-05-17 7:08 ` Patrick Steinhardt
2024-05-16 8:04 ` [PATCH 04/16] refs: track ref stores via strmap Patrick Steinhardt
2024-05-16 18:34 ` Junio C Hamano
2024-05-16 8:04 ` [PATCH 05/16] refs: pass repo when retrieving submodule ref store Patrick Steinhardt
2024-05-16 18:44 ` Junio C Hamano
2024-05-17 7:09 ` Patrick Steinhardt
2024-05-16 8:04 ` [PATCH 06/16] refs: refactor `resolve_gitlink_ref()` to accept a repository Patrick Steinhardt
2024-05-16 18:45 ` Junio C Hamano
2024-05-16 8:04 ` [PATCH 07/16] refs: retrieve worktree ref stores via associated repository Patrick Steinhardt
2024-05-16 8:04 ` [PATCH 08/16] refs: convert iteration over replace refs to accept ref store Patrick Steinhardt
2024-05-16 8:04 ` [PATCH 09/16] refs: pass ref store when detecting dangling symrefs Patrick Steinhardt
2024-05-16 8:04 ` [PATCH 10/16] refs: move object peeling into "object.c" Patrick Steinhardt
2024-05-16 20:55 ` Junio C Hamano [this message]
2024-05-16 8:05 ` [PATCH 11/16] refs: pass repo when peeling objects Patrick Steinhardt
2024-05-16 8:05 ` [PATCH 12/16] refs: drop `git_default_branch_name()` Patrick Steinhardt
2024-05-16 18:44 ` Karthik Nayak
2024-05-16 8:05 ` [PATCH 13/16] refs: remove `dwim_log()` Patrick Steinhardt
2024-05-16 8:05 ` [PATCH 14/16] refs/files: use correct repository Patrick Steinhardt
2024-05-16 8:05 ` [PATCH 15/16] refs/files: remove references to `the_hash_algo` Patrick Steinhardt
2024-05-16 8:05 ` [PATCH 16/16] refs/packed: " Patrick Steinhardt
2024-05-16 18:57 ` [PATCH 00/16] refs: drop all references to `the_repository` Karthik Nayak
2024-05-17 7:08 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqttixo4s1.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.