All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Joanna Wang <jojwang@google.com>,  git@vger.kernel.org,  tboegi@web.de
Subject: Re: [PATCH 1/1] attr: add builtin objectmode values support
Date: Thu, 16 Nov 2023 11:53:02 +0900	[thread overview]
Message-ID: <xmqqttpmtnn5.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cSyrD71NMnfVCTHEf+K8vop9QHLet7uyOerrq=v9SVbFw@mail.gmail.com> (Eric Sunshine's message of "Wed, 15 Nov 2023 20:37:11 -0500")

Eric Sunshine <sunshine@sunshineco.com> writes:

> A bit more idiomatic in this codebase would be:
>
>         git update-index --index-info <<-EOF
>         100755 $empty_blob 0    exec
>         120000 $empty_blob 0    symlink
>         EOF
>
> No need for `cat`.

Aye, of course.  We should not cat a single-source datastream into a
pipe.  Thanks for correcting me.

  reply	other threads:[~2023-11-16  2:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-14  2:28 [PATCH 1/1] attr: add native file mode values support Joanna Wang
2023-11-14  2:52 ` Junio C Hamano
2023-11-14 21:49   ` [PATCH 1/1] attr: add builtin objectmode " Joanna Wang
2023-11-16  1:26     ` Junio C Hamano
2023-11-16  1:37       ` Eric Sunshine
2023-11-16  2:53         ` Junio C Hamano [this message]
2023-11-16  5:44           ` Joanna Wang
2023-11-16  6:17             ` Junio C Hamano
2023-11-16  8:08               ` Junio C Hamano
2023-11-16 17:54                 ` Joanna Wang
2023-12-01  4:01                 ` Joanna Wang
2023-12-12 23:17                   ` Junio C Hamano
2023-12-20 20:07                     ` Junio C Hamano
2024-01-12  6:12                       ` Joanna Wang
2023-11-16  7:57             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqttpmtnn5.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jojwang@google.com \
    --cc=sunshine@sunshineco.com \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.