From: Junio C Hamano <gitster@pobox.com>
To: Naomi Ibe <naomi.ibeh69@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 1/1] [OUTREACHY] builtin/add.c: clean up die() messages
Date: Tue, 17 Oct 2023 15:16:06 -0700 [thread overview]
Message-ID: <xmqqttqox5cp.fsf@gitster.g> (raw)
In-Reply-To: <20231017221323.352-1-naomi.ibeh69@gmail.com> (Naomi Ibe's message of "Tue, 17 Oct 2023 23:13:23 +0100")
Naomi Ibe <naomi.ibeh69@gmail.com> writes:
> As described in the CodingGuidelines document, a single line
> message given to die() and its friends should not capitalize its
> first word, and should not add full-stop at the end.
>
> Signed-off-by: Naomi Ibe <naomi.ibeh69@gmail.com>
> ---
> builtin/add.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Looks good. Will queue. Thanks.
prev parent reply other threads:[~2023-10-17 22:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 22:13 [PATCH v2 1/1] [OUTREACHY] builtin/add.c: clean up die() messages Naomi Ibe
2023-10-17 22:16 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqttqox5cp.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=naomi.ibeh69@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.