From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH] repack: free existing_cruft array after use
Date: Mon, 09 Oct 2023 10:28:13 -0700 [thread overview]
Message-ID: <xmqqttqz1z9u.fsf@gitster.g> (raw)
In-Reply-To: <ZSNWZ9+Q2eOpy91A@nand.local> (Taylor Blau's message of "Sun, 8 Oct 2023 21:24:55 -0400")
Taylor Blau <me@ttaylorr.com> writes:
> On Sat, Oct 07, 2023 at 01:20:31PM -0400, Jeff King wrote:
>> On Mon, Oct 02, 2023 at 08:44:32PM -0400, Taylor Blau wrote:
>> ...
>> Coverity (using the just-merged-to-next version of the workflow file!)
>> flagged a leak here. Since the topic (tb/repack-max-cruft-size) is in
>> 'next', I think we'd want this on top:
>
> Woohoo! I'm glad that this is already paying dividends.
> ...
> Thanks, I can't believe I missed this when writing this function. The
> fix looks obviously correct to me, so this has my:
>
> Acked-by: Taylor Blau <me@ttaylorr.com>
>
> Thanks,
Will queue. Thanks.
prev parent reply other threads:[~2023-10-09 17:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 21:51 [PATCH 0/2] repack: implement `--cruft-max-size` Taylor Blau
2023-09-07 21:52 ` [PATCH 1/2] t7700: split cruft-related tests to t7704 Taylor Blau
2023-09-08 0:01 ` Eric Sunshine
2023-09-07 21:52 ` [PATCH 2/2] builtin/repack.c: implement support for `--cruft-max-size` Taylor Blau
2023-09-07 23:42 ` Junio C Hamano
2023-09-25 18:01 ` Taylor Blau
2023-09-08 11:21 ` Patrick Steinhardt
2023-10-02 20:30 ` Taylor Blau
2023-10-03 0:44 ` [PATCH v2 0/3] repack: implement `--cruft-max-size` Taylor Blau
2023-10-03 0:44 ` [PATCH v2 1/3] t7700: split cruft-related tests to t7704 Taylor Blau
2023-10-03 0:44 ` [PATCH v2 2/3] builtin/repack.c: parse `--max-pack-size` with OPT_MAGNITUDE Taylor Blau
2023-10-05 11:31 ` Patrick Steinhardt
2023-10-05 17:28 ` Taylor Blau
2023-10-05 20:22 ` Junio C Hamano
2023-10-03 0:44 ` [PATCH v2 3/3] builtin/repack.c: implement support for `--max-cruft-size` Taylor Blau
2023-10-05 12:08 ` Patrick Steinhardt
2023-10-05 17:35 ` Taylor Blau
2023-10-05 20:25 ` Junio C Hamano
2023-10-07 17:20 ` [PATCH] repack: free existing_cruft array after use Jeff King
2023-10-09 1:24 ` Taylor Blau
2023-10-09 17:28 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqttqz1z9u.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.