From: Junio C Hamano <gitster@pobox.com>
To: Jeff Hostetler <git@jeffhostetler.com>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, Jeff Hostetler <jeffhostetler@github.com>,
Eric DeCosta <edecosta@mathworks.com>
Subject: Re: [PATCH 0/8] fsmonitor unused parameter cleanups
Date: Tue, 19 Sep 2023 11:09:02 -0700 [thread overview]
Message-ID: <xmqqttrqf329.fsf@gitster.g> (raw)
In-Reply-To: <7356bb25-12aa-dc6a-9b32-87d13c49994c@jeffhostetler.com> (Jeff Hostetler's message of "Tue, 19 Sep 2023 09:34:07 -0400")
Jeff Hostetler <git@jeffhostetler.com> writes:
> On 9/18/23 6:29 PM, Jeff King wrote:
>> Here are a few cleanups of the fsmonitor code to remove or annotate
>> unused parameters (working towards my goal of making us compile clean
> ...
> LGTM
>
> Thanks,
> Jeff
Thanks, both. Let's merge it down.
prev parent reply other threads:[~2023-09-19 18:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 22:29 [PATCH 0/8] fsmonitor unused parameter cleanups Jeff King
2023-09-18 22:29 ` [PATCH 1/8] fsmonitor: prefer repo_git_path() to git_pathdup() Jeff King
2023-09-18 22:30 ` [PATCH 2/8] fsmonitor/win32: drop unused parameters Jeff King
2023-09-18 22:31 ` [PATCH 3/8] fsmonitor: mark some maybe-unused parameters Jeff King
2023-09-18 22:32 ` [PATCH 4/8] fsmonitor/win32: mark unused parameter in fsm_os__incompatible() Jeff King
2023-09-18 22:32 ` [PATCH 5/8] fsmonitor: mark unused parameters in stub functions Jeff King
2023-09-18 22:32 ` [PATCH 6/8] fsmonitor/darwin: mark unused parameters in system callback Jeff King
2023-09-18 22:33 ` [PATCH 7/8] fsmonitor: mark unused hashmap callback parameters Jeff King
2023-09-18 22:33 ` [PATCH 8/8] run-command: mark unused parameters in start_bg_wait callbacks Jeff King
2023-09-19 13:34 ` [PATCH 0/8] fsmonitor unused parameter cleanups Jeff Hostetler
2023-09-19 18:09 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqttrqf329.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=edecosta@mathworks.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=jeffhostetler@github.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.