All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: <rsbecker@nexbridge.com>
Cc: "'Taylor Blau'" <me@ttaylorr.com>,
	"'Christian Hesse'" <list@eworm.de>, <git@vger.kernel.org>,
	"'Christian Hesse'" <mail@eworm.de>
Subject: Re: [PATCH 1/1] imap-send: include strbuf.h
Date: Wed, 17 May 2023 11:12:16 -0700	[thread overview]
Message-ID: <xmqqttwaq133.fsf@gitster.g> (raw)
In-Reply-To: <016701d988ea$4e4ffcd0$eaeff670$@nexbridge.com> (rsbecker@nexbridge.com's message of "Wed, 17 May 2023 14:06:24 -0400")

<rsbecker@nexbridge.com> writes:

>>Oof, yes, you are right:
>>
>>    diff -u \
>>      <(gcc -I . -E imap-send.c) \
>>      <(gcc -DNO_CURL=1 -I . -E imap-send.c)
>>
>>How *should* we test this?
>
> I hope not by using gcc, which is not currently a
> dependency. Using the C preprocessor directly might help in a more
> general sense, but you probably will need a knob for some
> compilers to work.

I am not going to suggest trying all permutations of CPP macros to
make sure we cover all the #ifdef'ed sections, but -E to show CPP
output is pretty common feature not limited to "gcc", so if we were
to do that, we'd very likely use the usual $(CC) Makefile macro to
invoke such a test.

  reply	other threads:[~2023-05-17 18:12 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-17  7:06 [PATCH 1/1] imap-send: include strbuf.h Christian Hesse
2023-05-17 15:49 ` Junio C Hamano
2023-05-17 16:02   ` Taylor Blau
2023-05-17 16:19     ` Junio C Hamano
2023-05-17 16:31       ` Taylor Blau
2023-05-17 20:12       ` Christian Hesse
2023-05-17 20:18         ` Christian Hesse
2023-05-18 15:56           ` Junio C Hamano
2023-05-17 16:23     ` Taylor Blau
2023-05-17 16:53       ` Junio C Hamano
2023-05-17 17:01         ` Junio C Hamano
2023-05-17 17:58           ` Taylor Blau
2023-05-17 18:06             ` rsbecker
2023-05-17 18:12               ` Junio C Hamano [this message]
2023-05-17 19:30                 ` rsbecker
2023-05-17 18:09             ` Junio C Hamano
2023-05-17 21:38               ` Taylor Blau
2023-05-18 16:01                 ` Junio C Hamano
2023-05-18 18:25                   ` Jeff King
2023-05-18 20:49                     ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2024-02-09 22:26 Christian Hesse
2024-02-09 22:42 ` Junio C Hamano
2024-02-09 22:54   ` Junio C Hamano
2024-02-10 20:01     ` Christian Hesse
2024-02-11  2:42       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqttwaq133.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=list@eworm.de \
    --cc=mail@eworm.de \
    --cc=me@ttaylorr.com \
    --cc=rsbecker@nexbridge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.