All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Robin Jarry" <robin@jarry.cc>
Cc: git@vger.kernel.org, "Phillip Wood" <phillip.wood123@gmail.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Tim Culverhouse" <tim@timculverhouse.com>,
	"Nicolas Dichtel" <nicolas.dichtel@6wind.com>,
	"Bagas Sanjaya" <bagasdotme@gmail.com>,
	"Eric Sunshine" <sunshine@sunshineco.com>,
	"Michael Strawbridge" <michael.strawbridge@amd.com>
Subject: Re: [PATCH v5] send-email: export patch counters in validate environment
Date: Thu, 20 Apr 2023 12:25:31 -0700	[thread overview]
Message-ID: <xmqqttxaz784.fsf@gitster.g> (raw)
In-Reply-To: <CS1TOE1MCMH0.2OMA9UHSDG7RC@ringo> (Robin Jarry's message of "Thu, 20 Apr 2023 21:16:05 +0200")

"Robin Jarry" <robin@jarry.cc> writes:

> I had an idea after sending v5. Instead of leaving TODO placeholders, it
> would be nicer to introduce other git config sendemail.validate* options
> specific to this hook template so that users can directly use it without
> any modifications simply by setting options in their local clone:
>
>     git config sendemail.validatePatchCmd 'tools/checkpatch.sh'
>     git config sendemail.validateSeriesCmd 'make tests lint'
>
> And reuse these commands if defined in the hook template.

I do not think it is worth it, as they have to write the scripts or
copy them from elsewhere, *and* need to make the configuration
variables, *and* make the sample hook into a real one with such an
approach.

After all, it is merely a sample.  There is a value in keeping it
simple so that users can learn what the structure should look like.
Then users will come up with something much better suited for their
own use case themselves.

Thanks.

      reply	other threads:[~2023-04-20 19:25 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-11 11:47 [PATCH] send-email: export patch counters in validate environment Robin Jarry
2023-04-11 13:23 ` Phillip Wood
2023-04-11 16:28   ` Junio C Hamano
2023-04-11 17:13     ` Robin Jarry
2023-04-11 19:14       ` Junio C Hamano
2023-04-11 16:47   ` Robin Jarry
2023-04-12  9:54 ` [PATCH v2] " Robin Jarry
2023-04-12 17:53   ` Junio C Hamano
2023-04-12 18:33     ` Robin Jarry
2023-04-12 20:37       ` Junio C Hamano
2023-04-12 20:39         ` Robin Jarry
2023-04-12 21:48     ` Junio C Hamano
2023-04-12 21:45   ` [PATCH v3] " Robin Jarry
2023-04-13 13:52     ` Phillip Wood
2023-04-13 14:01       ` Robin Jarry
2023-04-14 12:58         ` Phillip Wood
2023-04-14 15:28     ` [PATCH v4] " Robin Jarry
2023-04-14 15:50       ` Robin Jarry
2023-04-14 15:52       ` [PATCH v5] " Robin Jarry
2023-04-20 19:16         ` Robin Jarry
2023-04-20 19:25           ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqttxaz784.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=bagasdotme@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=michael.strawbridge@amd.com \
    --cc=nicolas.dichtel@6wind.com \
    --cc=phillip.wood123@gmail.com \
    --cc=robin@jarry.cc \
    --cc=sunshine@sunshineco.com \
    --cc=tim@timculverhouse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.