Re: [PATCH] add basic http proxy tests

[Junio C Hamano <gitster@pobox.com>]

Jeff King <peff@peff.net> writes:

> Here is that patch. Even though it didn't lead me anywhere useful in
> debugging your problem, it may be worth picking up anyway just to get
> better test coverage.
> ...
>   - I'm using a single apache instance to proxy to itself. This seems to
>     work fine in practice, and we can check with a test that this rather
>     unusual setup is doing what we expect.

Cute.

>   - I've put the proxy tests into their own script, and it's the only
>     one which loads the apache proxy config. If any platform can't
>     handle this (e.g., doesn't have the right modules), the start_httpd
>     step should fail and gracefully skip the rest of the script (but all
>     the other http tests in existing scripts will continue to run).

Nice.  I have to move it from 5563 to 5564, though.

>   - On the client side, we test two situations with credentials: when
>     they are present in the url, and when the username is present but we
>     prompt for the password. I think we should be able to handle the
>     case that _neither_ is present, but an HTTP 407 causes us to prompt
>     for them. However, this doesn't seem to work. That's either a bug,
>     or at the very least an opportunity for a feature, but I punted on
>     it for now. The point of this patch is just getting basic coverage,
>     and we can explore possible deficiencies later.

OK.

Thanks.