From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Ignacio Taranto <ignacio.taranto@eclypsium.com>, git@vger.kernel.org
Subject: Re: About git reporting missing newline for symlinks
Date: Thu, 13 Oct 2022 11:50:06 -0700 [thread overview]
Message-ID: <xmqqtu47fti9.fsf@gitster.g> (raw)
In-Reply-To: <221013.86k053lkvu.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Thu, 13 Oct 2022 18:57:44 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>>> \ The filename pointed to by the symlink does not end in a newline
>>
>> While I do not think it would break anybody, I doubt it would give
>> us much value. One line above that output is a line that any user,
>> who is vaguely familiar with the contents being compared, can
>> recognize as giving a pathname, the contents of the symbolic link.
>
> Clearly it confused the initial reporter upthread :)
But to such a user, I highly suspect that the rephased message above
still looks like a warning, and will result in the same reaction.
IOW, you want to explain why "does not end in a newline" is worth
expressing in the output. Saying "does not end in a newline" alone
would tell the user what they already know (i.e. the symlink stores
the target filename without an extra LF at the end).
next prev parent reply other threads:[~2022-10-13 18:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 21:17 About git reporting missing newline for symlinks Ignacio Taranto
2022-10-12 21:31 ` Junio C Hamano
2022-10-12 21:42 ` Ignacio Taranto
2022-10-13 13:11 ` Ævar Arnfjörð Bjarmason
2022-10-13 16:02 ` Junio C Hamano
2022-10-13 16:57 ` Ævar Arnfjörð Bjarmason
2022-10-13 18:50 ` Junio C Hamano [this message]
2022-10-13 19:33 ` Ævar Arnfjörð Bjarmason
2022-10-13 20:06 ` Junio C Hamano
2022-10-13 20:34 ` Philip Oakley
2022-10-13 22:01 ` Erik Cervin Edin
2022-10-12 21:32 ` brian m. carlson
2022-10-12 21:34 ` Junio C Hamano
2022-10-12 21:42 ` brian m. carlson
2022-10-13 2:17 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtu47fti9.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=ignacio.taranto@eclypsium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.