From: Junio C Hamano <gitster@pobox.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] completion: tcsh: Fix regression by drop of wrapper functions
Date: Wed, 18 Aug 2021 13:57:23 -0700 [thread overview]
Message-ID: <xmqqtujm4gjw.fsf@gitster.g> (raw)
In-Reply-To: <20210818132729.26021-1-tiwai@suse.de> (Takashi Iwai's message of "Wed, 18 Aug 2021 15:27:29 +0200")
Takashi Iwai <tiwai@suse.de> writes:
> The cleanup of old compat wrappers in bash completion caused a
> regression on tcsh completion that still uses them.
> Let's update the tcsh call site as well for addressing it.
>
> Fixes: 441ecdab37fe ("completion: bash: remove old compat wrappers")
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
> contrib/completion/git-completion.tcsh | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Thanks. Will queue.
> diff --git a/contrib/completion/git-completion.tcsh b/contrib/completion/git-completion.tcsh
> index 4a790d8f4ec1..ba797e5b3cd5 100644
> --- a/contrib/completion/git-completion.tcsh
> +++ b/contrib/completion/git-completion.tcsh
> @@ -80,8 +80,9 @@ else
> COMP_CWORD=\$((\${#COMP_WORDS[@]}-1))
> fi
>
> -# Call _git() or _gitk() of the bash script, based on the first argument
> -_\${1}
> +# Call __git_wrap__git_main() or __git_wrap__gitk_main() of the bash script,
> +# based on the first argument
> +__git_wrap__\${1}_main
>
> IFS=\$'\n'
> if [ \${#COMPREPLY[*]} -eq 0 ]; then
prev parent reply other threads:[~2021-08-18 20:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 13:27 [PATCH] completion: tcsh: Fix regression by drop of wrapper functions Takashi Iwai
2021-08-18 20:57 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtujm4gjw.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.