Re: [PATCH v3 5/5] [GSOC] ref-filter: add %(rest) atom

[Junio C Hamano <gitster@pobox.com>]

Jacob Keller <jacob.keller@gmail.com> writes:

> On Sat, Jul 24, 2021 at 7:14 AM ZheNing Hu via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>>
>> From: ZheNing Hu <adlternative@gmail.com>
>>
>> %(rest) is a atom used for cat-file batch mode, which can split
>> the input lines at the first whitespace boundary, all characters
>> before that whitespace are considered to be the object name;
>> characters after that first run of whitespace (i.e., the "rest"
>> of the line) are output in place of the %(rest) atom.
>>
>> In order to let "cat-file --batch=%(rest)" use the ref-filter
>> interface, add %(rest) atom for ref-filter.
>>
>> Introduce the reject_atom() to reject the atom %(rest) for
>> "git for-each-ref", "git branch", "git tag" and "git verify-tag".
>>
>> Suggected-by: Jacob Keller <jacob.keller@gmail.com>
>> Mentored-by: Christian Couder <christian.couder@gmail.com>
>> Mentored-by: Hariom Verma <hariom18599@gmail.com>
>> Signed-off-by: ZheNing Hu <adlternative@gmail.com>
>> ---
>
> Thanks for the improved  commit message here. That helps clarify what
> this atom does and aids in understanding the implementation.
>
> Reviewed-by: Jacob Keller <jacob.keller@gmail.com>

Thanks, both.