All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org,
	"Luc Van Oostenryck" <luc.vanoostenryck@gmail.com>,
	"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH 1/2] gc docs: change --keep-base-pack to --keep-largest-pack
Date: Sat, 21 Nov 2020 11:43:59 -0800	[thread overview]
Message-ID: <xmqqtutisdfk.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20201120115522.23617-1-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Fri, 20 Nov 2020 12:55:21 +0100")

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> The --keep-base-pack option never existed in git.git. It was the name
> for the --keep-largest-pack option in earlier revisions of that series
> before it landed as ae4e89e549 ("gc: add --keep-largest-pack option",
> 2018-04-15).

Is it a sign that this hasn't been used by or useful to our users
that this documentation bug did not get noticed by anybody for the
past 30 months, I wonder.

"git gc -h" does report the option with correct name, which is the
beauty of automation ;-)

Thanks, both.  Will queue, together with [2/2] which also makes
sense.

  reply	other threads:[~2020-11-21 19:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-06 21:49 gc docs: git gc --keep-base-pack ? Luc Van Oostenryck
2020-11-20 11:55 ` [PATCH 1/2] gc docs: change --keep-base-pack to --keep-largest-pack Ævar Arnfjörð Bjarmason
2020-11-21 19:43   ` Junio C Hamano [this message]
2020-11-23 10:18     ` Ævar Arnfjörð Bjarmason
2020-11-20 11:55 ` [PATCH 2/2] gc: rename keep_base_pack variable for --keep-largest-pack Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtutisdfk.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=luc.vanoostenryck@gmail.com \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.