From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>, Johannes Sixt <j6t@kdbg.org>,
Benoit Lecocq <benoit@openbsd.org>
Subject: Re: [PATCH] t1002: stop using sum(1)
Date: Mon, 14 Aug 2017 13:35:36 -0700 [thread overview]
Message-ID: <xmqqtw19ubtz.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <9f6e13d3-07ff-1eaa-9453-05ca26a3c1ff@web.de> ("René Scharfe"'s message of "Mon, 14 Aug 2017 22:16:34 +0200")
René Scharfe <l.s.r@web.de> writes:
> It's more convenient because it shows differences nicely, it's faster on
> MinGW because we have a special implementation there based only on
> shell-internal commands,...
This made me wonder why we are not using that "faster" one
everywhere, but it turns out that it depends on bash-ism "local",
which is perfectly fine when limited to MinGW but not safe to assume
in general.
> ...
> With all sum(1) calls gone, remove the MinGW-specific implementation
> from test-lib.sh as well.
>
> [1] http://minnie.tuhs.org/cgi-bin/utree.pl?file=V3/man/man1/sum.1
> [2] http://minnie.tuhs.org/cgi-bin/utree.pl?file=4.4BSD/usr/share/man/cat1/cksum.0
> [3] http://pubs.opengroup.org/onlinepubs/9699919799/utilities/cksum.html
> ---
> t/t1002-read-tree-m-u-2way.sh | 67 ++++++++++++++++++++++---------------------
> t/test-lib.sh | 3 --
> 2 files changed, 35 insertions(+), 35 deletions(-)
Sounds like a sensible approach to clean things up; I didn't check
with fine toothed comb if the patch does follow that approach
correctly without breaking things, though.
next prev parent reply other threads:[~2017-08-14 20:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 20:16 [PATCH] t1002: stop using sum(1) René Scharfe
2017-08-14 20:35 ` Junio C Hamano [this message]
2017-08-15 0:46 ` Jonathan Nieder
2017-08-15 6:27 ` Johannes Sixt
2017-08-15 14:43 ` René Scharfe
2017-08-15 14:37 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtw19ubtz.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=benoit@openbsd.org \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.