All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] fixup! log: add exhaustive tests for pattern style options & config
Date: Sat, 13 May 2017 07:32:04 +0900	[thread overview]
Message-ID: <xmqqtw4p4sgr.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <92c10618c688bb8cb1f31ee2a93110c581974468.1494586245.git.johannes.schindelin@gmx.de> (Johannes Schindelin's message of "Fri, 12 May 2017 12:50:55 +0200 (CEST)")

Johannes Schindelin <johannes.schindelin@gmx.de> writes:

> On Windows, `(1|2)` is not a valid file name, and therefore the tag
> cannot be created as expected by the new test.
>
> So simply skip this test on Windows.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---

Will queue as an emergency fix on 'pu' for now, but I'd expect
(read: ask) Ævar to squash this in when the series is rerolled.

Thanks.

> Published-As: https://github.com/dscho/git/releases/tag/exhaustive-grep-tests-fixup-v1
> Fetch-It-Via: git fetch https://github.com/dscho/git exhaustive-grep-tests-fixup-v1
>
>  t/t4202-log.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t4202-log.sh b/t/t4202-log.sh
> index 36321f19061..6f108e99b7b 100755
> --- a/t/t4202-log.sh
> +++ b/t/t4202-log.sh
> @@ -296,7 +296,7 @@ test_expect_success 'log with grep.patternType configuration and command line' '
>  	test_cmp expect actual
>  '
>  
> -test_expect_success 'log with various grep.patternType configurations & command-lines' '
> +test_expect_success !MINGW 'log with various grep.patternType configurations & command-lines' '
>  	git init pattern-type &&
>  	(
>  		cd pattern-type &&
>
> base-commit: 3760a479060228867a31eed443334b30124465b9

  reply	other threads:[~2017-05-12 22:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-12 10:50 [PATCH] fixup! log: add exhaustive tests for pattern style options & config Johannes Schindelin
2017-05-12 22:32 ` Junio C Hamano [this message]
2017-05-12 23:44 ` Jonathan Nieder
2017-05-13 13:22   ` Ævar Arnfjörð Bjarmason
2017-05-13 19:03   ` Johannes Schindelin
2017-05-15 19:04     ` Jonathan Nieder
2017-05-13 13:20 ` Ævar Arnfjörð Bjarmason
2017-05-15  2:18   ` Junio C Hamano
2017-05-15 12:19     ` Johannes Schindelin
2017-05-16  0:46       ` Junio C Hamano
2017-05-16  6:15         ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtw4p4sgr.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.