From: Junio C Hamano <gitster@pobox.com>
To: Sveinung Kvilhaugsvik <sveinung84@users.sourceforge.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-completion: add stashes for gitk
Date: Fri, 13 Mar 2015 22:18:31 -0700 [thread overview]
Message-ID: <xmqqtwxoxil4.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CANAO8VEUu9erxMLU523vQhg1hyfwVASH-Ng6YGKTN0RiB+H9FQ@mail.gmail.com> (Sveinung Kvilhaugsvik's message of "Fri, 13 Mar 2015 18:25:48 +0100")
Sveinung Kvilhaugsvik <sveinung84@users.sourceforge.net> writes:
>> A bigger question is why this change is made to gitk completion. If
>> this completion were useful for "gitk", wouoldn't it be equally
>> useful for "git log"?
> I must admit that I didn't know that "git log" could display the
> content of a stashed change. After trying "git log -p -m stash@{0}" I
> would say that adding stashes for "git log" would be slightly less
> useful.
Yeah, it would not be so useful to dig with "log" beyond the commit
that each stash entry is based on. But imagine "git show stash@{....}"
or "git log -g stash@{0}"?
prev parent reply other threads:[~2015-03-14 5:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 0:42 [PATCH] git-completion: add stashes for gitk Sveinung Kvilhaugsvik
2015-03-12 18:11 ` Junio C Hamano
2015-03-12 18:40 ` Junio C Hamano
2015-03-13 17:25 ` Sveinung Kvilhaugsvik
2015-03-14 5:18 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtwxoxil4.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sveinung84@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.