From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: "git\@vger.kernel.org" <git@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] hex.c: reduce memory footprint of sha1_to_hex static buffers
Date: Fri, 13 Feb 2015 15:45:20 -0800 [thread overview]
Message-ID: <xmqqtwypl6jz.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAGZ79kaEun-mEQPg7cmPV7RJR8A+BxSsSpeAQgcsuJn8L4TGEg@mail.gmail.com> (Stefan Beller's message of "Fri, 13 Feb 2015 13:56:37 -0800")
Stefan Beller <sbeller@google.com> writes:
> On Fri, Feb 13, 2015 at 1:41 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Stefan Beller <sbeller@google.com> writes:
>>
>>> 41 bytes is the exact number of bytes needed for having the returned
>>> hex string represented. 50 seems to be an arbitrary number, such
>>> that there are no benefits from alignment to certain address boundaries.
>>
>> Yes, with s/seems to be/is/;
>>
>> This comes from e83c5163 (Initial revision of "git", the information
>> manager from hell, 2005-04-07), and when dcb3450f (sha1_to_hex()
>> usage cleanup, 2006-05-03) introduced the "4 recycled buffers" on
>> top, the underlying array was left at 50 bytes long.
>>
>> You can now have "I fixed Linus's bug" badge ;-)
>
> I don't think it's a bug, it's just wasting memory?
Yes and no ;-) As I already said above, 50 "is" just an arbitrary
number that is round and enough to hold 40 bytes with trailing NUL,
and the waste does not lead to behaviour that is different from what
was intended, of course, so it would not crash.
However, the wastage was bothersome enough to make you send a patch,
so you can call it a "bug". It was wasting readers time ;-)
prev parent reply other threads:[~2015-02-13 23:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 21:18 [PATCH] hex.c: reduce memory footprint of sha1_to_hex static buffers Stefan Beller
2015-02-13 21:41 ` Junio C Hamano
2015-02-13 21:56 ` Stefan Beller
2015-02-13 21:58 ` Linus Torvalds
2015-02-13 23:45 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtwypl6jz.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.