From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Torsten Bögershausen" <tboegi@web.de>, git@vger.kernel.org
Subject: Re: [PATCH] t5705: Use the correct file:// URL
Date: Thu, 13 Nov 2014 08:37:48 -0800 [thread overview]
Message-ID: <xmqqtx232h0j.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20141113091724.GB8329@peff.net> (Jeff King's message of "Thu, 13 Nov 2014 04:17:24 -0500")
Jeff King <peff@peff.net> writes:
> On Thu, Nov 13, 2014 at 08:36:07AM +0100, Torsten Bögershausen wrote:
>
>> A URL like file;//. is (no longer) supported by Git:
>> Typically there is no host, and RFC1738 says that file:///<path>
>> should be used.
>>
>> Update t5705 to use a working URL.
>
> Interesting. This looks like it was unintentionally lost in c59ab2e
> (connect.c: refactor url parsing, 2013-11-28). Given RFC1738, and that
> this is the first notice of it (and that it is not even a real use case,
> but something questionable in the test script), it's probably OK to
> declare the syntax dead and not treat it like a regression.
Yeah, I tend to agree. I do not think there is any <scheme>:// that
lets you say things relative to something that is not "root" of the
namespace, and it was a bug the old test depended on that we did not
notice it as an error when "file://." tried to refer to "the current
directory".
prev parent reply other threads:[~2014-11-13 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 7:36 [PATCH] t5705: Use the correct file:// URL Torsten Bögershausen
2014-11-13 9:17 ` Jeff King
2014-11-13 16:37 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtx232h0j.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.