All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Thomas Gummerer <t.gummerer@gmail.com>
Cc: git@vger.kernel.org, pclouds@gmail.com, sunshine@sunshineco.com
Subject: Re: [PATCH v2 0/3] Easier access to index-v4
Date: Mon, 24 Feb 2014 13:39:39 -0800	[thread overview]
Message-ID: <xmqqtxbo6vhg.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <87y510s2xh.fsf@hank.lan> (Thomas Gummerer's message of "Mon, 24 Feb 2014 20:53:14 +0100")

Thomas Gummerer <t.gummerer@gmail.com> writes:

>> Something along this line, perhaps?
>
> Sorry about this, I didn't run the test suite without
> TEST_GIT_INDEX_VERSION in config.mak which I obviously should have.
>
> Yes, this looks good to me, thanks!

OK, will squash it (but using "VAR:+isset" instead of "VAR+isset" to
allow people to set it to empty to disable) into the relevant patch.

Thanks.

      reply	other threads:[~2014-02-24 21:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-23 20:49 [PATCH v2 0/3] Easier access to index-v4 Thomas Gummerer
2014-02-23 20:49 ` [PATCH v2 1/3] introduce GIT_INDEX_VERSION environment variable Thomas Gummerer
2014-02-23 20:49 ` [PATCH v2 2/3] test-lib: allow setting the index format version Thomas Gummerer
2014-02-23 20:49 ` [PATCH v2 3/3] read-cache: add index.version config variable Thomas Gummerer
2014-02-24 17:56 ` [PATCH v2 0/3] Easier access to index-v4 Junio C Hamano
2014-02-24 19:35   ` Junio C Hamano
2014-02-24 19:53     ` Thomas Gummerer
2014-02-24 21:39       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtxbo6vhg.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    --cc=sunshine@sunshineco.com \
    --cc=t.gummerer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.