From: Junio C Hamano <gitster@pobox.com>
To: Francesco Pretto <ceztko@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-submodule.sh: Support 'checkout' as a valid update command
Date: Mon, 06 Jan 2014 15:48:53 -0800 [thread overview]
Message-ID: <xmqqtxdgfz8a.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1389034726-8744-1-git-send-email-ceztko@gmail.com> (Francesco Pretto's message of "Mon, 6 Jan 2014 19:58:46 +0100")
Francesco Pretto <ceztko@gmail.com> writes:
> According to "Documentation/gitmodules.txt", 'checkout' is a valid
> 'submodule.<name>.update' command.
As you can see in the surrounding text, we call the value of
submodule.*.update a "mode", not a command.
> Also "git-submodule.sh" refers to
> it and processes it correctly.
This present tense puzzles me. If it already refers to checkout and
handles it correctly is there anything that needs to be done? Or
did you mean "it should refer to and process it but it doesn't, so
make it so?"
> Reflecting commit 'ac1fbb' to support
> this syntax and also validate property values during 'update' command,
> issuing an error if the value found is unknown.
Sorry, but -ECANNOTPARSE.
next prev parent reply other threads:[~2014-01-06 23:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 18:58 [PATCH] git-submodule.sh: Support 'checkout' as a valid update command Francesco Pretto
2014-01-06 23:48 ` Junio C Hamano [this message]
2014-01-07 0:05 ` Francesco Pretto
2014-01-07 16:12 ` Junio C Hamano
2014-01-07 17:42 ` Francesco Pretto
2014-01-07 1:16 ` Francesco Pretto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtxdgfz8a.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=ceztko@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.