From: Junio C Hamano <gitster@pobox.com>
To: Yusuke Hayashi via B4 Relay <devnull+yusuke8h.gmail.com@kernel.org>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
Karthik Nayak <karthik.188@gmail.com>,
Yusuke Hayashi <yusuke8h@gmail.com>
Subject: Re: [PATCH] refs: drop unused `peel_iterated_oid()` declaration
Date: Thu, 12 Nov 2026 10:45:00 -0800 [thread overview]
Message-ID: <xmqqv761j3df.fsf@gitster.g> (raw)
In-Reply-To: <20261112-refs-drop-peel-iterated-oid-v1-1-7df1c313e293@gmail.com> (Yusuke Hayashi via's message of "Thu, 12 Nov 2026 05:57:35 +0000")
Yusuke Hayashi via B4 Relay <devnull+yusuke8h.gmail.com@kernel.org>
writes:
> From: Yusuke Hayashi <yusuke8h@gmail.com>
>
> Commit 5a5c7359f7 (refs: drop `current_ref_iter` hack, 2025-10-23)
> removed `peel_iterated_oid()` from "refs.c" after converting all of its
> callers to `reference_get_peeled_oid()`, leaving behind the declaration
> in "refs.h".
>
> Remove the unused declaration and its comment.
>
> Signed-off-by: Yusuke Hayashi <yusuke8h@gmail.com>
> ---
> refs.h | 13 -------------
> 1 file changed, 13 deletions(-)
obviously correct ;-) Thanks, will queue.
>
> diff --git a/refs.h b/refs.h
> index ee3b8a62ef..73076cba2f 100644
> --- a/refs.h
> +++ b/refs.h
> @@ -178,19 +178,6 @@ void ref_store_release(struct ref_store *ref_store);
> */
> int ref_store_remove_on_disk(struct ref_store *refs, struct strbuf *err);
>
> -/*
> - * Return the peeled value of the oid currently being iterated via
> - * for_each_ref(), etc. This is equivalent to calling:
> - *
> - * peel_object(r, oid, &peeled);
> - *
> - * with the "oid" value given to the refs_for_each_cb callback, except
> - * that some ref storage may be able to answer the query without
> - * actually loading the object in memory.
> - */
> -int peel_iterated_oid(struct repository *r,
> - const struct object_id *base, struct object_id *peeled);
> -
> /**
> * Resolve refname in the nested "gitlink" repository in the specified
> * submodule (which must be non-NULL). If the resolution is
>
> ---
> base-commit: 1891de46f79dc444a47db1c87bd0c8c76b5463f2
> change-id: 20261112-refs-drop-peel-iterated-oid-ede2901e1c5a
prev parent reply other threads:[~2026-11-12 18:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 5:57 [PATCH] refs: drop unused `peel_iterated_oid()` declaration Yusuke Hayashi
2026-11-12 5:57 ` Yusuke Hayashi via B4 Relay
2026-11-12 18:45 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv761j3df.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=devnull+yusuke8h.gmail.com@kernel.org \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=ps@pks.im \
--cc=yusuke8h@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.