Re: [PATCH] add -i: hide init/clear_add_i_state() functions

[Junio C Hamano <gitster@pobox.com>]

Patrick Steinhardt <ps@pks.im> writes:

> On Wed, Oct 28, 2026 at 12:57:51PM -0700, Junio C Hamano wrote:
>> The "add -i" machinery is encapsulated in run_add_i() function,
>> which uses init_add_i_state() to initialize the machinery, does its
>> thing, and clear_add_i_state() to tear it down.  External callers
>> have no need to call anything other than run_add_i().
>> 
>> Make init/clear_add_i_state() file-scope static functions, and
>> "struct add_i_state" type as well.
>
> Nice cleanup. For historical context, these declarations are not needed
> anymore starting with d51b61f5dab (add-patch: remove dependency on
> "add-interactive" subsystem, 2026-03-02).

Thanks.  I did not notice that I gave a backstory for the other
three commits but apparently did so without digging into the history
for this one.

By the way, I queued the patches sent to the list on a branch (I
initially made them on a detached HEAD without keeping a local copy
after sending them out) and tried 'git history reword' to update
this one, but it seems it does not honor the notes.rewriteref
configuration variable.  I wonder if this is a known limitation, or
a deliberate design.

Thanks.