All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Aniket Gupta <aniketgupta3001@gmail.com>
Cc: Xiangfei Ding <xfding@google.com>,
	"brian m. carlson" <sandals@crustytoothpaste.net>,
	git@vger.kernel.org, dev+git@drbeat.li, davidben@google.com,
	dingxiangfei2009@protonmail.ch
Subject: Re: [PATCH] imap-send: use ASN1_STRING_length
Date: Mon, 12 Oct 2026 10:18:24 -0700	[thread overview]
Message-ID: <xmqqv77696sf.fsf@gitster.g> (raw)
In-Reply-To: <20261012151748.62723-1-aniketgupta3001@gmail.com> (Aniket Gupta's message of "Mon, 12 Oct 2026 15:17:48 +0000")

Aniket Gupta <aniketgupta3001@gmail.com> writes:

> Hello Xiangfei,
>
>> +	int pat_len = ASN1_STRING_length(asn1_str);
>
> It seems that with OpenSSL 4.1.0-beta2 this is deprecated
> (ASN1_STRING_get_length() is the replacement), so it warns, and
> fails with DEVELOPER=1. The patch adds a second use at the error
> message. Beat Bolli has a series from 7 Sept ("imap-send: future
> proofing and two correctness fixes") that also touches
> host_matches(), maybe we can check how the two can fit together?
>
> Thanks,
> Aniket

[jch: rewrapped long unreadable lines]

That topic also needs rework, unfortunately.

  https://lore.kernel.org/git/20260907211210.2621693-1-dev+git@drbeat.li/

I guess we can salvage the patches 1 and 2 with fairly trivial
changes, namely with the style fix in [1/3], and pointer arithmetic
that breaks later free() fix in [2/3].  I am not sure how involved
it would be to fix [3/3] in such a way suggested by brian in the
thread.

Thanks for reminding us of the old thread.



  reply	other threads:[~2026-10-12 17:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-11 21:09 [PATCH] imap-send: use ASN1_STRING_length Xiangfei Ding
2026-10-11 23:05 ` Junio C Hamano
2026-10-12 15:17 ` Aniket Gupta
2026-10-12 17:18   ` Junio C Hamano [this message]
2026-10-12 20:09     ` Beat Bolli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv77696sf.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=aniketgupta3001@gmail.com \
    --cc=davidben@google.com \
    --cc=dev+git@drbeat.li \
    --cc=dingxiangfei2009@protonmail.ch \
    --cc=git@vger.kernel.org \
    --cc=sandals@crustytoothpaste.net \
    --cc=xfding@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.