All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>,
	 Phillip Wood <phillip.wood@dunelm.org.uk>,
	 git@vger.kernel.org
Subject: Re: [PATCH 2/2] builtin/init-db: deprecate alias for git-init(1)
Date: Tue, 02 Jun 2026 17:27:41 +0900	[thread overview]
Message-ID: <xmqqv7c1xs76.fsf@gitster.g> (raw)
In-Reply-To: <ah58IJ8DgSZYRjMM@pks.im> (Patrick Steinhardt's message of "Tue, 2 Jun 2026 08:45:52 +0200")

Patrick Steinhardt <ps@pks.im> writes:

> I wouldn't mind that outcome much, either. What triggered this series is
> that I'm always annoyed that it's "builtin/init-db.c" instead of
> "builtin/init.c", and the same for `cmd_init_db()`. But I intentionally
> constructed the series in a way that the first commit can be picked
> as-is, so that we can adjust our code to the modern world while not
> doing the deprecation dance.
>
> So I'd be equally happy if we just drop the second commit in this
> series.

I'd actually find myself annoyed by such a rename when looking for
builtin/init-db.c only to find it gone---much like how a previous
rename made ll-merge difficult to locate.

My point is that while static names may annoy some, renaming them
does not resolve the annoyance; it merely shifts it to someone else.

So, if the primary motivation is just the first patch, I would be
less inclined to support this series.

  parent reply	other threads:[~2026-06-02  8:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01  7:55 [PATCH 0/2] Deprecate git-init-db(1) alias Patrick Steinhardt
2026-06-01  7:55 ` [PATCH 1/2] builtin/init-db: rename to "builtin/init.c" Patrick Steinhardt
2026-06-01  7:56 ` [PATCH 2/2] builtin/init-db: deprecate alias for git-init(1) Patrick Steinhardt
2026-06-01  9:31   ` Kristoffer Haugsbakk
2026-06-01 12:10     ` Patrick Steinhardt
2026-06-01 13:48       ` Phillip Wood
2026-06-01 14:20         ` Patrick Steinhardt
2026-06-01 21:23           ` Kristoffer Haugsbakk
2026-06-01 22:22             ` Junio C Hamano
2026-06-02  6:45               ` Patrick Steinhardt
2026-06-02  7:54                 ` Kristoffer Haugsbakk
2026-06-02 12:34                   ` Patrick Steinhardt
2026-06-02  8:27                 ` Junio C Hamano [this message]
2026-06-02 12:34                   ` Patrick Steinhardt
2026-06-02 13:12                     ` Phillip Wood
2026-06-02 14:58                       ` Patrick Steinhardt
2026-06-02 15:24                     ` SZEDER Gábor
2026-06-01 22:18           ` Junio C Hamano
2026-06-02 13:09           ` Phillip Wood
2026-06-02 13:50             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv7c1xs76.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.