From: Junio C Hamano <gitster@pobox.com>
To: "D. Ben Knoble" <ben.knoble@gmail.com>
Cc: kristofferhaugsbakk@fastmail.com, git@vger.kernel.org,
Kristoffer Haugsbakk <code@khaugsbakk.name>
Subject: Re: [PATCH 0/4] doc: am: improve command linking and add am.messageId
Date: Mon, 09 Feb 2026 14:22:16 -0800 [thread overview]
Message-ID: <xmqqv7g536cn.fsf@gitster.g> (raw)
In-Reply-To: <CALnO6CBTWTqfVNerHQb0X4Y4UKXggRdqzgXqYKd_O05shC+jNA@mail.gmail.com> (D. Ben Knoble's message of "Mon, 9 Feb 2026 16:57:45 -0500")
"D. Ben Knoble" <ben.knoble@gmail.com> writes:
> On Mon, Feb 9, 2026 at 12:35 PM <kristofferhaugsbakk@fastmail.com> wrote:
>>
>> From: Kristoffer Haugsbakk <code@khaugsbakk.name>
>>
>> Topic name: kh/doc-am-messageid
>>
>> Topic summary: I noticed that `am.messageId` was not documented. In the
>> process I thought that the way that git-am(1) refers to commands is a
>> bit off. Replace all things like 'git am'/`git rebase` with
>> `linkgit`. Also fill out hook documentation.
>>
>> Notes to the maintainer: this conflicts with topic
>> kh/doc-am-format-sendmail in `seen` because of an adjacent paragraph.
>>
>> Kristoffer Haugsbakk (4):
>> doc: am: normalize git(1) command links
>> doc: am: say that --message-id adds a trailer
>> doc: am: add missing config am.messageId
>> doc: am: fill out hook discussion
>>
>> Documentation/config/am.adoc | 24 +++++++++------
>> Documentation/git-am.adoc | 58 ++++++++++++++++++++----------------
>> 2 files changed, 47 insertions(+), 35 deletions(-)
>>
>>
>> base-commit: 67ad42147a7acc2af6074753ebd03d904476118f
>> --
>> 2.53.0.26.g2afa8602a26
>
> From a quick glance I don't spot any issues. Thanks!
Yeah, thanks, both. Queued.
prev parent reply other threads:[~2026-02-09 22:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 17:34 [PATCH 0/4] doc: am: improve command linking and add am.messageId kristofferhaugsbakk
2026-02-09 17:34 ` [PATCH 1/4] doc: am: normalize git(1) command links kristofferhaugsbakk
2026-02-11 17:32 ` Kristoffer Haugsbakk
2026-02-09 17:34 ` [PATCH 2/4] doc: am: say that --message-id adds a trailer kristofferhaugsbakk
2026-02-09 17:34 ` [PATCH 3/4] doc: am: add missing config am.messageId kristofferhaugsbakk
2026-02-09 17:34 ` [PATCH 4/4] doc: am: fill out hook discussion kristofferhaugsbakk
2026-02-09 21:57 ` [PATCH 0/4] doc: am: improve command linking and add am.messageId D. Ben Knoble
2026-02-09 22:22 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv7g536cn.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble@gmail.com \
--cc=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.