All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Todd Zullinger <tmz@pobox.com>,
	 git@vger.kernel.org,  Kousik Sanagavarapu <five231003@gmail.com>,
	 brian m. carlson <sandals@crustytoothpaste.net>
Subject: Re: [PATCH] t1016-compatObjectFormat: Really freeze time for reproduciblity
Date: Tue, 28 Oct 2025 10:15:23 -0700	[thread overview]
Message-ID: <xmqqv7jzc5hw.fsf@gitster.g> (raw)
In-Reply-To: <87frb310d2.fsf_-_@email.froward.int.ebiederm.org> (Eric W. Biederman's message of "Tue, 28 Oct 2025 11:01:45 -0500")

"Eric W. Biederman" <ebiederm@xmission.com> writes:

> By default gpg still allows time to move forward with --faked-system-time.
> So in those rare instances when the system is heavily loaded an gpg runs
> slower than other times, signatures over the exact same data differ
> due to timestamps with a minuscule difference.
>
> Reading through the gpg documentation with a close eye, time can be
> frozen by including an exclamation point at the end of the argument to
> --faked-system-time.
> ...
>  t/t1016-compatObjectFormat.sh | 6 ++++++
>  t/t1016/gpg                   | 2 +-
>  2 files changed, 7 insertions(+), 1 deletion(-)

Geez, how are we expected to find the need for '!' ourselves X-<.

Thanks for root causing the issue so quickly once it was raised.

And let me drop the "let's disable flakey ones" band-aid patch from
the queue.


  reply	other threads:[~2025-10-28 17:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-03 15:37 [PATCH 0/2] t/lib-gpg: ensure GNUPGHOME is created as needed Todd Zullinger
2024-07-03 15:37 ` [PATCH 1/2] t/lib-gpg: add prepare_gnupghome() to create GNUPGHOME dir Todd Zullinger
2024-07-03 15:37 ` [PATCH 2/2] t/lib-gpg: call prepare_gnupghome() in GPG2 prereq Todd Zullinger
2024-07-03 16:29 ` [PATCH 0/2] t/lib-gpg: ensure GNUPGHOME is created as needed Todd Zullinger
2025-02-28 15:26   ` Todd Zullinger
2025-10-26  1:25     ` Junio C Hamano
2025-10-27 16:16       ` Eric W. Biederman
2025-10-27 17:38         ` Junio C Hamano
2025-10-27 19:03           ` Eric W. Biederman
2025-10-27 19:32             ` Eric W. Biederman
2025-10-27 20:32               ` Junio C Hamano
2025-10-28 16:01                 ` [PATCH] t1016-compatObjectFormat: Really freeze time for reproduciblity Eric W. Biederman
2025-10-28 17:15                   ` Junio C Hamano [this message]
2025-10-29  3:05                     ` Todd Zullinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv7jzc5hw.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=ebiederm@xmission.com \
    --cc=five231003@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=sandals@crustytoothpaste.net \
    --cc=tmz@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.