All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Jeff King <peff@peff.net>,  git@vger.kernel.org
Subject: Re: What's cooking in git.git (Aug 2025, #01; Sun, 3)
Date: Tue, 05 Aug 2025 10:10:33 -0700	[thread overview]
Message-ID: <xmqqv7n1zoc6.fsf@gitster.g> (raw)
In-Reply-To: <aJIBlIDto33lJEuK@pks.im> (Patrick Steinhardt's message of "Tue, 5 Aug 2025 15:05:24 +0200")

Patrick Steinhardt <ps@pks.im> writes:

> So with that knowledge I'd rather do the safe thing and abort the
> transaction. It requires less hard-to-test logic and feels safer
> overall.
>
> If we agree on that I can send a final reroll that reverts back to the
> logic we had in v3, which did abort the transaction.

I guess both you and Peff also prefer code that is more maintainable
and easier to reason about, and I am with you two, so let's go back
to the approach of v3.

Thanks.



  parent reply	other threads:[~2025-08-05 17:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-04  8:23 What's cooking in git.git (Aug 2025, #01; Sun, 3) Junio C Hamano
2025-08-04  9:47 ` Patrick Steinhardt
2025-08-04 14:29   ` Junio C Hamano
2025-08-04 14:51     ` Patrick Steinhardt
2025-08-04 15:41       ` Jeff King
2025-08-05  0:34         ` Junio C Hamano
2025-08-05 12:51           ` Jeff King
2025-08-05 17:08             ` Junio C Hamano
2025-08-05 18:48               ` Jeff King
2025-08-05 13:05           ` Patrick Steinhardt
2025-08-05 13:44             ` Jeff King
2025-08-05 17:10             ` Junio C Hamano [this message]
2025-08-05  1:22 ` D. Ben Knoble
2025-08-05 10:24   ` Junio C Hamano
2025-08-05 16:23     ` D. Ben Knoble
2025-08-05 16:30       ` D. Ben Knoble
2025-08-05 19:06         ` Junio C Hamano
2025-08-05 19:18           ` Ben Knoble
2025-08-06 17:28           ` Lucas Seiki Oshiro
2025-08-06 18:34             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv7n1zoc6.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.