From: Junio C Hamano <gitster@pobox.com>
To: "Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH] merge-file doc: set conflict-marker-size attribute
Date: Sat, 29 Mar 2025 16:36:45 -0700 [thread overview]
Message-ID: <xmqqv7rrbe9e.fsf@gitster.g> (raw)
In-Reply-To: <pull.1895.git.1743173140253.gitgitgadget@gmail.com> (Phillip Wood via GitGitGadget's message of "Fri, 28 Mar 2025 14:45:40 +0000")
"Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> When committing a conflict resolution for a merge containing
> 1f010d6bdf7 (doc: use .adoc extension for AsciiDoc files, 2025-01-20)
> my pre-commit hook failed because "git diff --check" thought there was
> a left over conflict marker in "merge-file.adoc". Fix this by setting
> the "conflict-marker-size" attribute as we do for all the other
> documentation files that contain example conflict markers.
>
> Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
> ---
> merge-file doc: set conflict-marker-size attribute
>
> Grepping around I can't find any other files with conflict markers
> without this attribute set. (If there were I think my pre-commit hook
> would have complained about them as well)
Well spotted. "git grep -n '^<<<<<<<'" tells me that the
git-merge-file, git-merge, and user-manual require them, but this
was a rather old line dating back from 2008, so it is a bit
surprising nobody caught it before.
Will queue. Thanks.
prev parent reply other threads:[~2025-03-29 23:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 14:45 [PATCH] merge-file doc: set conflict-marker-size attribute Phillip Wood via GitGitGadget
2025-03-29 23:36 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv7rrbe9e.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.