From: Junio C Hamano <gitster@pobox.com>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: git@vger.kernel.org, "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH] docs: clarify meaning of core.commentString=auto
Date: Mon, 17 Mar 2025 13:17:54 -0700 [thread overview]
Message-ID: <xmqqv7s78l8t.fsf@gitster.g> (raw)
In-Reply-To: <20250315140913.577404-1-oswald.buddenhagen@gmx.de> (Oswald Buddenhagen's message of "Sat, 15 Mar 2025 15:09:13 +0100")
Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes:
> -If set to "auto", `git-commit` would select a character that is not
> -the beginning character of any line in existing commit messages.
This is so far in the past but I suspect this was deliberately left
vague so that we can add (or subtract) the set of possible letters
to use.
> +If set to "auto", `git-commit` will select the first character
> +from the set "#;@!$%^&|:" that does not appear at the beginning
> +of any line in the prepared commit message prior to editing.
So I am not sure if this is an improvement.
> +Note that this makes it impossible to include comments in the
> +prepare-commit-msg hook's output or the commit message template.
Care to rephrase? There are degrees of possibilities and "makes it
impossible" is being overly broad.
I suspect you are saying that it is not nice to make it the
responsibility of the end-user who chooses "auto" to ensure that
they adjust the default '#' comments injected from the template or
hook output when
- they have a line that begins with '#' in their message;
- the "auto" mechanism chooses to use ';' as the comment character;
- the template is written assuming '#' as the comment character and
has comments.
before making a commit. But "this makes it impossible" does not
quite convey that to casual readers.
Thanks.
next prev parent reply other threads:[~2025-03-17 20:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-15 14:09 [PATCH] docs: clarify meaning of core.commentString=auto Oswald Buddenhagen
2025-03-17 20:17 ` Junio C Hamano [this message]
2025-03-17 21:34 ` Taylor Blau
2025-03-18 11:43 ` Oswald Buddenhagen
2025-03-18 17:15 ` Junio C Hamano
2025-03-19 18:20 ` Oswald Buddenhagen
2025-03-20 10:21 ` Phillip Wood
2025-03-21 10:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv7s78l8t.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=oswald.buddenhagen@gmx.de \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.