All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Mahendra Dani <danimahendra0904@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [GSOC][PATCH v3 0/1] t1403: verify path exists and is a file
Date: Tue, 04 Mar 2025 08:00:36 -0800	[thread overview]
Message-ID: <xmqqv7soss4b.fsf@gitster.g> (raw)
In-Reply-To: <20250304094153.28959-1-danimahendra0904@gmail.com> (Mahendra Dani's message of "Tue, 4 Mar 2025 15:11:52 +0530")

Mahendra Dani <danimahendra0904@gmail.com> writes:

> test -e does not provide a nice error message when we hit test failures,
> so use test_path_exists() instead.
>
> Further, verify that if the path exists, then the path is a file using
> test_path_is_file() helper function.
>
> This patch does not change any code in v2, but is rather submitted with proper formatting
> which was lacking in v2. 
> I apologize for the incorrect patch submission in v2. 

My cursory look didn't spot anything iffy in v2 and I found it
nicely described.  I do not see anything, other than the above
3-line paragraph, that is different in v3 from v2, which is a bit
curious.

Thanks.

  parent reply	other threads:[~2025-03-04 16:00 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-01 10:58 [GSOC][PATCH 0/1] t1403: prefer test_path_exists helper function Mahendra Dani
2025-03-01 10:58 ` [PATCH 1/1] " Mahendra Dani
2025-03-03 10:26   ` Patrick Steinhardt
2025-03-04  2:27     ` Mahendra Dani
2025-03-04 12:05       ` Junio C Hamano
2025-03-04 17:24         ` Mahendra Dani
2025-03-04 17:26           ` Junio C Hamano
2025-03-04 17:35             ` Mahendra Dani
2025-03-04 17:44               ` Junio C Hamano
2025-03-04 17:49                 ` Mahendra Dani
2025-03-04 18:07                   ` Junio C Hamano
2025-03-04 17:35         ` Eric Sunshine
2025-03-04 17:49           ` Junio C Hamano
2025-03-04 18:07             ` Eric Sunshine
2025-03-04 18:28               ` Eric Sunshine
2025-03-04 18:30               ` Junio C Hamano
2025-03-04  9:15 ` [GSOC][PATCH v2 0/1] t1403: verify path exists and is a file Mahendra Dani
2025-03-04  9:41   ` [GSOC][PATCH v3 " Mahendra Dani
2025-03-04  9:41     ` [PATCH v3 1/1] t1403: verify that " Mahendra Dani
2025-03-04 18:05       ` Junio C Hamano
2025-03-04 18:06         ` Junio C Hamano
2025-03-04 18:13           ` Mahendra Dani
2025-03-04 11:23     ` [PATCH v4 0/1] t1403: verify " Mahendra Dani
2025-03-04 11:27     ` Mahendra Dani
2025-03-04 11:27       ` [PATCH v4 1/1] t1403: verify that " Mahendra Dani
2025-03-04 18:13         ` Junio C Hamano
2025-03-04 18:19           ` Mahendra Dani
2025-03-04 16:00     ` Junio C Hamano [this message]
2025-03-04  9:27 ` [PATCH v2 " Mahendra Dani
2025-03-04 11:02   ` Patrick Steinhardt
2025-03-04 11:15     ` Mahendra Dani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv7soss4b.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=danimahendra0904@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.