From: Junio C Hamano <gitster@pobox.com>
To: "Kristoffer Haugsbakk" <code@khaugsbakk.name>
Cc: "David Disseldorp" <ddiss@suse.de>,
"Teng Long" <dyroneteng@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 1/2] t3301-notes: check editor isn't invoked for empty notes add
Date: Thu, 25 Jul 2024 10:10:27 -0700 [thread overview]
Message-ID: <xmqqv80tfldo.fsf@gitster.g> (raw)
In-Reply-To: <5fdccb84-1e60-477e-99d9-b22e3ef83f54@app.fastmail.com> (Kristoffer Haugsbakk's message of "Thu, 25 Jul 2024 17:52:25 +0200")
"Kristoffer Haugsbakk" <code@khaugsbakk.name> writes:
> Introducing a regression test in one patch and then fixing the bug (and
> making the test pass) in the next patch is a style that some prefer. But
> I have received feedback before that it’s best to avoid that.
Especially for something very small like this topic, yes.
next prev parent reply other threads:[~2024-07-25 17:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 14:41 [PATCH 0/2] notes: fix editor invocation regression David Disseldorp
2024-07-25 14:41 ` [PATCH 1/2] t3301-notes: check editor isn't invoked for empty notes add David Disseldorp
2024-07-25 15:52 ` Kristoffer Haugsbakk
2024-07-25 16:03 ` David Disseldorp
2024-07-25 17:10 ` Junio C Hamano [this message]
2024-07-25 16:31 ` Junio C Hamano
2024-07-25 23:10 ` David Disseldorp
2024-07-25 14:41 ` [PATCH 2/2] notes: revert note_data.given behavior with " David Disseldorp
2024-07-25 17:09 ` Junio C Hamano
2024-07-25 17:22 ` Kristoffer Haugsbakk
2024-07-25 23:26 ` David Disseldorp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv80tfldo.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=code@khaugsbakk.name \
--cc=ddiss@suse.de \
--cc=dyroneteng@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.