From: Junio C Hamano <gitster@pobox.com>
To: Dragan Simic <dsimic@manjaro.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] documentation: send-email: use camel case consistently
Date: Mon, 19 Feb 2024 16:52:43 -0800 [thread overview]
Message-ID: <xmqqv86kx8h0.fsf@gitster.g> (raw)
In-Reply-To: <b0577267402f6177d8ba5646e12d7691437e6e8f.1708060779.git.dsimic@manjaro.org> (Dragan Simic's message of "Fri, 16 Feb 2024 06:19:56 +0100")
Dragan Simic <dsimic@manjaro.org> writes:
> Correct a few random "sendemail.*" configuration parameter names in the
> documentation that, for some reason, didn't use camel case format.
Thanks.
> There's only one "Fixes" tag, while there should actually be a whole bunch
> of them to cover all the patches that introduced the configuration parameter
> names fixed by this patch. I think we're fine with just one.
I suspect that we are even better off without any. The only reason
to have them is if we plan to cherry-pick this patch down to a
separate maintenance track that the "culprit" was cherry-picked or
merged to, but we typically do not do so, and if we want to do so,
we'd need a much better coverage.
Anyway, checking the output of
$ git grep -n -e '^[a-z]*\.[a-z]*[A-Z][A-Z][a-zA-Z]*::' Documentation/config/
and comparing it with the output of
$ git grep -n -e '^[a-z]*\.[a-z]*[A-Z][a-zA-Z]*::' Documentation/config/
I think we should spell "SSL" (which is an acronym) full in capital,
and possibly do the same for "CC", too.
All the other updates in this patch looked sensible, but I wasn't
being particularly careful, so an extra set or two of eyes are
certainly appreciated in case I missed any.
Thanks.
next prev parent reply other threads:[~2024-02-20 0:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 5:19 [PATCH] documentation: send-email: use camel case consistently Dragan Simic
2024-02-20 0:52 ` Junio C Hamano [this message]
2024-02-20 6:41 ` Dragan Simic
2024-02-20 16:22 ` Junio C Hamano
2024-02-20 16:29 ` Dragan Simic
2024-02-20 16:50 ` Dragan Simic
2024-02-20 18:29 ` Junio C Hamano
2024-02-20 19:38 ` Dragan Simic
2024-02-21 0:43 ` Chris Torek
2024-02-21 7:50 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv86kx8h0.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dsimic@manjaro.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.