All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jacob Keller <jacob.keller@gmail.com>
Cc: Borislav Petkov <bp@alien8.de>, git@vger.kernel.org
Subject: Re: git send-email -v
Date: Wed, 09 Aug 2023 12:11:31 -0700	[thread overview]
Message-ID: <xmqqv8dom3oc.fsf@gitster.g> (raw)
In-Reply-To: <CA+P7+xrGBNO-JNfHvbVUV9AgY_Q8PgYSr5EVycGzC5+ZB7Cv3A@mail.gmail.com> (Jacob Keller's message of "Wed, 9 Aug 2023 10:42:54 -0700")

Jacob Keller <jacob.keller@gmail.com> writes:

> In short: this is working as intended, but it is somewhat confusing
> that it doesn't validate the argument at all. It is intentional to
> allow non-numeric strings, but maybe we ought to validate that it
> doesn't start with -- to avoid such confusion here.

I think both of your points are quite reasonable here.

      parent reply	other threads:[~2023-08-09 19:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09 17:00 git send-email -v Borislav Petkov
2023-08-09 17:42 ` Jacob Keller
2023-08-09 17:46   ` Borislav Petkov
2023-08-09 19:11   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv8dom3oc.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=bp@alien8.de \
    --cc=git@vger.kernel.org \
    --cc=jacob.keller@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.