From: Junio C Hamano <gitster@pobox.com>
To: Alex Riesen <alexander.riesen@cetitec.com>
Cc: "Taylor Blau" <me@ttaylorr.com>,
git@vger.kernel.org, "Elijah Newren" <newren@gmail.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: Crashes in t/t4058-diff-duplicates.sh
Date: Fri, 06 May 2022 09:30:34 -0700 [thread overview]
Message-ID: <xmqqv8uioc7p.fsf@gitster.g> (raw)
In-Reply-To: <YnT19KB2XkBrJOLQ@pflmari> (Alex Riesen's message of "Fri, 6 May 2022 12:18:28 +0200")
Alex Riesen <alexander.riesen@cetitec.com> writes:
> Taylor Blau, Fri, May 06, 2022 05:31:12 +0200:
>> t4058.16, which blames back to ac14de13b2 (t4058: explore duplicate tree
That commit talks about "trees with duplicate entries". Does it
mean a bad history where a tree object has two or more entries under
the same name? We should of course be catching these things at fsck
time and rejecting at network transfer time, but I agree it is not a
good excuse for us to segfault. We should diagnose it as a broken
tree object and actively refuse to proceed by calling die().
next prev parent reply other threads:[~2022-05-06 16:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 8:53 Crashes in t/t4058-diff-duplicates.sh Alex Riesen
[not found] ` <YnSWgDdxgm+XWiLt@nand.local>
2022-05-06 10:18 ` Alex Riesen
2022-05-06 16:30 ` Junio C Hamano [this message]
2022-05-07 4:14 ` Elijah Newren
2022-05-09 15:23 ` Taylor Blau
2022-05-10 3:50 ` Elijah Newren
2022-05-09 12:51 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv8uioc7p.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=alexander.riesen@cetitec.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=newren@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.