From: Junio C Hamano <gitster@pobox.com>
To: Philip Oakley <philipoakley@iee.email>
Cc: Philip Oakley via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] README.md: add CodingGuidelines and a link for Translators
Date: Fri, 14 Jan 2022 16:47:28 -0800 [thread overview]
Message-ID: <xmqqv8yl6d0f.fsf@gitster.g> (raw)
In-Reply-To: <6b626f9d-05d6-1903-0b38-e3566e357472@iee.email> (Philip Oakley's message of "Sat, 15 Jan 2022 00:08:05 +0000")
Philip Oakley <philipoakley@iee.email> writes:
> Unfortunately it `[]` is not working for me for the new additions.
> GitHub magic?
Let's step back a bit.
Is there somebody reading README.md as a more generic MarkDown? I
do not think our build procedure creates any rendered document from
it.
My recollection was that we moved from README.txt to README.md for
the sole purpose of showing it https://github.com/git/git/ as more
than just a plain text, so it is a hard requirement that GitHub
flavored MarkDown renderer is happy with whatever we write in the
file.
If GitHub flavored MarkDown only supports [] and breaks with (),
then there is no need for further discussion. We must stick to []
that has been working for us in the file.
On the other hand, if both () and [] work well at GitHub, I am OK to
replace [] to (), so that it shows well at GitHub and also it can be
used with other MarkDown renderers.
I prefer, from the organizational point of view, to see two patches,
in this order, if we were to go that way.
[PATCH 1/2] README: link to more contributor documents
which uses [] (not ()). After this, README.md uses only [],
including the two links you add in this step. And then
[PATCH 2/2] README: use "()", not "[]", to please more MarkDown processors
which replaces all uses of [] with ().
That would allow us to queue both, try them out, and we can back out
[2/2] if GitHub's renderer does not like the result.
next prev parent reply other threads:[~2022-01-15 0:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 17:50 [PATCH] README.md: add CodingGuidelines and a link for Translators Philip Oakley via GitGitGadget
2022-01-14 20:54 ` Junio C Hamano
2022-01-15 0:08 ` Philip Oakley
2022-01-15 0:47 ` Junio C Hamano [this message]
2022-01-16 16:11 ` [PATCH v2] " Philip Oakley via GitGitGadget
2022-01-16 22:47 ` Junio C Hamano
2022-01-17 18:08 ` Philip Oakley
2022-01-17 9:00 ` Bagas Sanjaya
2022-01-17 17:52 ` Philip Oakley
2022-01-17 18:49 ` Junio C Hamano
2022-01-17 18:18 ` [PATCH v3] " Philip Oakley via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv8yl6d0f.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=philipoakley@iee.email \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.