From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEC96C433EF for ; Tue, 23 Nov 2021 21:57:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235668AbhKWWAt (ORCPT ); Tue, 23 Nov 2021 17:00:49 -0500 Received: from pb-smtp2.pobox.com ([64.147.108.71]:50563 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233507AbhKWWAq (ORCPT ); Tue, 23 Nov 2021 17:00:46 -0500 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 98081F2BC0; Tue, 23 Nov 2021 16:57:36 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=+wAE77gd2TsIivfKv7K2oBGPXPiKV0lDp00E/i iPFC8=; b=L9V7ftQC0TfFZDnVNmQXd5rdUwZJ7H892ImikChTVa9P8uIBLWpbUO Ho/HARdupFsgyRjszn/nGvTpp4efudcqOgovaYhhZLN+YaCsjOoN+vNv5ZhliPJ/ 6yLvLSIeVz/gZRyiFM4lwK9eciJ/WeR4c4nPNqqr9hfjIzUN4HDCs= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 8FD4AF2BBF; Tue, 23 Nov 2021 16:57:36 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.133.2.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 07E8BF2BBE; Tue, 23 Nov 2021 16:57:35 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Glen Choo Cc: Elijah Newren , Johannes Schindelin via GitGitGadget , Git Mailing List , Jeff King Subject: Re: [PATCH 8/8] dir: avoid removing the current working directory References: <20211123003958.3978-1-chooglen@google.com> Date: Tue, 23 Nov 2021 13:57:34 -0800 In-Reply-To: (Glen Choo's message of "Tue, 23 Nov 2021 12:32:43 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 5E369F16-4CA8-11EC-BC97-CD991BBA3BAF-77302942!pb-smtp2.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Glen Choo writes: > This doesn't sound like a typical definition of 'emptiness' to me, but I > can accept it if others also find it compelling. IOW if your definition > of 'emptiness' is compelling enough, then I'll be convinced that there > is no mixing of concerns and there would be no objection. FWIW, I do not find it compelling. I can grant that it might be convenient, but I do not think it is a good idea to explain the reason why the directory is protected is because it is "not empty".