All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Nils Leif Fischer via GitGitGadget" <gitgitgadget@gmail.com>,
	Derrick Stolee <dstolee@microsoft.com>
Cc: git@vger.kernel.org, Nils Leif Fischer <hello@nilsleiffischer.de>,
	Nils Leif Fischer <nils.fischer@aei.mpg.de>
Subject: Re: [PATCH] Fix a typo in git-maintenance documentation
Date: Fri, 19 Mar 2021 10:55:13 -0700	[thread overview]
Message-ID: <xmqqv99nm3jy.fsf@gitster.g> (raw)
In-Reply-To: <pull.984.git.git.1616149021392.gitgitgadget@gmail.com> (Nils Leif Fischer via GitGitGadget's message of "Fri, 19 Mar 2021 10:17:01 +0000")

"Nils Leif Fischer via GitGitGadget" <gitgitgadget@gmail.com>
writes:

> From: Nils Leif Fischer <nils.fischer@aei.mpg.de>
>
> Signed-off-by: Nils Leif Fischer <nils.fischer@aei.mpg.de>
> ---
>     Fix typo in git-maintenance documentation
>     
>     Just a small typo.

This is from the very beginning at 2057d750 (maintenance: create
basic maintenance runner, 2020-09-17), I think.

> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-984%2Fnilsleiffischer%2Fnilsleiffischer-patch-1-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-984/nilsleiffischer/nilsleiffischer-patch-1-v1
> Pull-Request: https://github.com/git/git/pull/984
>
>  Documentation/git-maintenance.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-maintenance.txt b/Documentation/git-maintenance.txt
> index 80ddd33ceba0..8023504dc65d 100644
> --- a/Documentation/git-maintenance.txt
> +++ b/Documentation/git-maintenance.txt
> @@ -106,7 +106,7 @@ any object transfer.
>  
>  gc::
>  	Clean up unnecessary files and optimize the local repository. "GC"
> -	stands for "garbage collection," but this task performs many
> +	stands for "garbage collection", but this task performs many

Isn't this merely an American style vs British style issue?


>  	smaller tasks. This task can be expensive for large repositories,
>  	as it repacks all Git objects into a single pack-file. It can also
>  	be disruptive in some situations, as it deletes stale data. See
>
> base-commit: a5828ae6b52137b913b978e16cd2334482eb4c1f


cf.

https://www.grammarly.com/blog/quotation-marks
https://www.thepunctuationguide.com/british-versus-american-style.html
https://owl.purdue.edu/owl/general_writing/punctuation/quotation_marks/more_quotation_mark_rules.html

  reply	other threads:[~2021-03-19 17:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19 10:17 [PATCH] Fix a typo in git-maintenance documentation Nils Leif Fischer via GitGitGadget
2021-03-19 17:55 ` Junio C Hamano [this message]
2021-03-19 18:37   ` Derrick Stolee
2021-03-19 20:19   ` Junio C Hamano
2021-03-20  1:55     ` Derrick Stolee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv99nm3jy.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=hello@nilsleiffischer.de \
    --cc=nils.fischer@aei.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.