From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: "Michal Suchánek" <msuchanek@suse.de>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: Getting an actuallt useful merge base?
Date: Thu, 25 Feb 2021 12:03:58 -0800 [thread overview]
Message-ID: <xmqqv9afud75.fsf@gitster.g> (raw)
In-Reply-To: <CABPp-BGdFX6V+GNQ6JVnoY3S9cvA0mL+cKSnAhUhArQbGaD6vw@mail.gmail.com> (Elijah Newren's message of "Thu, 25 Feb 2021 11:52:06 -0800")
Elijah Newren <newren@gmail.com> writes:
>> It's like this
>>
>> T
>> ----o----o----o----o----o----o----o----o----o----o----o----o---(t)---o----o----
>> \ \ \ \\\
>> \ \ \ \\\
>> \ \ \ \\\
>> \ o----o----o\̶---o---(s)---o----o----o----o----o----o\̶\̶-(a)
>> \ / \ / \\
>> S+T o----o----o----o----o----o----o----o----o----o----o----o----o----o\̶--(b)
>> / / \
>> ---o----o----o----o----o----o----o----o----o----o----o----o----o----o----o---(m)
>>
>> So (t) is common ancestor for (a) and (b) that merge-base reports but it is
>> only ancestor for files in set T, and does not have files from set S at all.
>> The common ancestor I am insterested in is (s) which is merge base for both
>> sets of files.
>
> From git-merge-base(1):
>
> "When the history involves criss-cross merges, there can be more than
> one best common ancestor for two commits...When the --all option is
> not given, it is unspecified which best one is output."
>
> Perhaps you want to specify --all to git merge-base, and then perform
> additional checks on the output to select one yourself?
Ignore me, as it is likely I am just confused, but if we are merging
(a) and (b), I do not think (s) could be usable as a merge base; it
may be an ancestor of (a) but is not an ancestor of (b), no?
next prev parent reply other threads:[~2021-02-25 20:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 17:58 Getting an actuallt useful merge base? Michal Suchánek
2021-02-25 2:40 ` brian m. carlson
2021-02-25 18:29 ` Michal Suchánek
2021-02-25 19:52 ` Elijah Newren
2021-02-25 20:03 ` Junio C Hamano [this message]
2021-02-25 20:16 ` Elijah Newren
2021-02-25 20:26 ` Michal Suchánek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv9afud75.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=msuchanek@suse.de \
--cc=newren@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.