From: Junio C Hamano <gitster@pobox.com>
To: tboegi@web.de
Cc: git@vger.kernel.org
Subject: Re: [PATCH v1 1/1] check-non-portable-shell.pl: Quoted `wc -l` is not portable
Date: Mon, 11 Dec 2017 15:07:35 -0800 [thread overview]
Message-ID: <xmqqvahc50eg.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171210105013.3984-1-tboegi@web.de> (tboegi@web.de's message of "Sun, 10 Dec 2017 11:50:13 +0100")
tboegi@web.de writes:
> From: Torsten Bögershausen <tboegi@web.de>
>
> wc -l is used to count the number if lines in test scripts.
Hmmmm, "is used" -> "should not be used", probably.
Just say "Use test_line_count instead" and leave the explanation why
it is a better thing to use to fb3340a6 ("test-lib: introduce
test_line_count to measure files", 2010-10-31), perhaps?
next prev parent reply other threads:[~2017-12-11 23:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 21:46 What's cooking in git.git (Dec 2017, #01; Mon, 4) Junio C Hamano
2017-12-04 22:04 ` Jeff Hostetler
2017-12-04 22:26 ` Elijah Newren
2017-12-04 23:46 ` Jonathan Tan
2017-12-05 0:30 ` Junio C Hamano
2017-12-06 15:14 ` Lars Schneider
2017-12-06 16:03 ` Torsten Bögershausen
2017-12-06 16:48 ` Junio C Hamano
2017-12-07 15:48 ` Johannes Schindelin
2017-12-07 20:22 ` Todd Zullinger
2017-12-07 20:50 ` Junio C Hamano
2017-12-07 21:08 ` Lars Schneider
2017-12-07 21:21 ` Junio C Hamano
2017-12-07 21:08 ` Jeff Hostetler
2017-12-07 21:10 ` Junio C Hamano
2017-12-10 10:50 ` [PATCH v1 1/1] check-non-portable-shell.pl: Quoted `wc -l` is not portable tboegi
2017-12-10 13:59 ` Johannes Schindelin
2017-12-11 23:07 ` Junio C Hamano [this message]
2017-12-16 19:52 ` [PATCH v2 " tboegi
2017-12-17 0:06 ` Eric Sunshine
2017-12-21 21:26 ` [PATCH v3 " tboegi
2017-12-22 21:07 ` Junio C Hamano
2017-12-23 7:27 ` Torsten Bögershausen
2017-12-07 21:33 ` What's cooking in git.git (Dec 2017, #01; Mon, 4) Todd Zullinger
2017-12-09 14:46 ` Torsten Bögershausen
2017-12-10 13:50 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvahc50eg.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.